MusiController

PMD Results

The following document contains the results of PMD 3.9.

Files

org/musicontroller/DJ.java

Violation	Line
Avoid modifiers which are implied by the context	12
Avoid modifiers which are implied by the context	13
Avoid modifiers which are implied by the context	14
Avoid modifiers which are implied by the context	15
Avoid modifiers which are implied by the context	16
Avoid modifiers which are implied by the context	17
Avoid modifiers which are implied by the context	18
Avoid modifiers which are implied by the context	19
Avoid modifiers which are implied by the context	25
Avoid modifiers which are implied by the context	31
Avoid modifiers which are implied by the context	36
Avoid modifiers which are implied by the context	42
Avoid modifiers which are implied by the context	47
Avoid modifiers which are implied by the context	53
Avoid modifiers which are implied by the context	59
Avoid modifiers which are implied by the context	65
Avoid modifiers which are implied by the context	67
Avoid modifiers which are implied by the context	74
Avoid modifiers which are implied by the context	85
Avoid modifiers which are implied by the context	91
Avoid modifiers which are implied by the context	98
Avoid modifiers which are implied by the context	103

org/musicontroller/DJFactory.java

Violation	Line
The class 'DJFactory' has a Cyclomatic Complexity of 3 (Highest = 10).	19 - 136
Each class should declare at least one constructor	19 - 136
Avoid excessively long variable names like _candidateSelector	22
The method 'create' has a Cyclomatic Complexity of 10.	34 - 96
A method should have only one exit point, and that should be the last statement in the method	37
A method should have only one exit point, and that should be the last statement in the method	41
Avoid variables with short names like dj	44
A method should have only one exit point, and that should be the last statement in the method	49
These nested if statements could be combined	67 - 69
Assigning an Object to null is a code smell. Consider refactoring.	72
These nested if statements could be combined	84 - 86
Assigning an Object to null is a code smell. Consider refactoring.	89
Avoid variables with short names like cs	92

org/musicontroller/DJImpl.java

Violation	Line
The class 'DJImpl' has a Cyclomatic Complexity of 2 (Highest = 12).	18 - 466
The Logger variable declaration does not contain the static and final modifiers	19
The field name indicates a constant but its modifiers do not	19
Avoid excessively long variable names like _candidateselector	23
Private field '_requests' could be made final; it is only initialized in the declaration or constructor.	24
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	27
Avoid excessively long variable names like _nextMandatoryRequest	28
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	28
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	29
Private field '_lastplayed' could be made final; it is only initialized in the declaration or constructor.	30
Private field '_currentSong' could be made final; it is only initialized in the declaration or constructor.	34
Avoid excessively long variable names like _millisecondsplayed	35
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	35
Assigning an Object to null is a code smell. Consider refactoring.	39
Assigning an Object to null is a code smell. Consider refactoring.	43
Avoid if (x != y) ..; else ..;	121 - 133
Use block level rather than method level synchronization	143 - 167
A method should have only one exit point, and that should be the last statement in the method	146
A method should have only one exit point, and that should be the last statement in the method	150
Use block level rather than method level synchronization	239 - 247
Assigning an Object to null is a code smell. Consider refactoring.	246
Use block level rather than method level synchronization	255 - 258
Assigning an Object to null is a code smell. Consider refactoring.	347
The method 'peek' has a Cyclomatic Complexity of 12.	358 - 419
Avoid reassigning parameters such as 'count'	358
Use block level rather than method level synchronization	358 - 419
Avoid using if statements without curly braces	365
A method should have only one exit point, and that should be the last statement in the method	365
Avoid using if statements without curly braces	371
Assigning an Object to null is a code smell. Consider refactoring.	386
Use block level rather than method level synchronization	461 - 464

org/musicontroller/MusiController.java

Violation	Line
Avoid modifiers which are implied by the context	9
Avoid modifiers which are implied by the context	10
Avoid modifiers which are implied by the context	12
Avoid modifiers which are implied by the context	13

org/musicontroller/MusiControllerImpl.java

Violation	Line
Each class should declare at least one constructor	12 - 68
The String literal " for user " appears 5 times in this file; the first occurrence is on line 42	42

org/musicontroller/SongChangeListener.java

Violation	Line
Avoid modifiers which are implied by the context	17
Avoid modifiers which are implied by the context	23
Avoid modifiers which are implied by the context	29

org/musicontroller/UserProperties.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	1 - 145
Each class should declare at least one constructor	22 - 145
Avoid variables with short names like in	40
Avoid using if statements without curly braces	48
A method should have only one exit point, and that should be the last statement in the method	63
Avoid variables with short names like dj	75
A method should have only one exit point, and that should be the last statement in the method	78
A method should have only one exit point, and that should be the last statement in the method	84
Avoid using if statements without curly braces	128

org/musicontroller/core/AIBag.java

Violation	Line
The class 'AIBag' has a Cyclomatic Complexity of 3 (Highest = 11).	9 - 94
Avoid variables with short names like id	12
Avoid variables with short names like id	24
The method 'equals' has a Cyclomatic Complexity of 11.	41 - 78
A method should have only one exit point, and that should be the last statement in the method	43
A method should have only one exit point, and that should be the last statement in the method	74

org/musicontroller/core/AIRelation.java

Violation	Line
Each class should declare at least one constructor	11 - 71
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	12
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	13
Method names should not contain underscores	19
Method names should not contain underscores	27
Method names should not contain underscores	35
Method names should not contain underscores	43
Avoid variables with short names like o	53
Avoid using if statements without curly braces	54
A method should have only one exit point, and that should be the last statement in the method	54
A method should have only one exit point, and that should be the last statement in the method	58

org/musicontroller/core/Artist.java

Violation	Line
Avoid variables with short names like id	24
Assigning an Object to null is a code smell. Consider refactoring.	36
Assigning an Object to null is a code smell. Consider refactoring.	37
Assigning an Object to null is a code smell. Consider refactoring.	38
Avoid variables with short names like id	86
Assigning an Object to null is a code smell. Consider refactoring.	109
Avoid variables with short names like sb	121
Avoid using if statements without curly braces	136
Avoid variables with short names like i	143
Avoid excessively long variable names like bandalreadyincontracts	144
Assigning an Object to null is a code smell. Consider refactoring.	173
A method should have only one exit point, and that should be the last statement in the method	205

org/musicontroller/core/Band.java

Violation	Line
It is a good practice to call super() in a constructor	11 - 15
Assigning an Object to null is a code smell. Consider refactoring.	13
Avoid using if statements without curly braces	48
When doing a String.toLowerCase()/toUpperCase() call, use a Locale	60
Avoid variables with short names like o	77
Avoid variables with short names like sb	109

org/musicontroller/core/Contract_BA.java

Violation	Line
Avoid variables with short names like id	6
Assigning an Object to null is a code smell. Consider refactoring.	13
Assigning an Object to null is a code smell. Consider refactoring.	14
Assigning an Object to null is a code smell. Consider refactoring.	15
Assigning an Object to null is a code smell. Consider refactoring.	16
Avoid variables with short names like id	55

org/musicontroller/core/Contract_PS.java

Violation	Line
The class 'Contract_PS' has a Cyclomatic Complexity of 3 (Highest = 12).	10 - 134
Avoid variables with short names like id	11
Assigning an Object to null is a code smell. Consider refactoring.	18
Assigning an Object to null is a code smell. Consider refactoring.	19
Avoid variables with short names like id	27
Avoid variables with short names like c	62
A method should have only one exit point, and that should be the last statement in the method	68
A method should have only one exit point, and that should be the last statement in the method	70
A method should have only one exit point, and that should be the last statement in the method	73
A method should have only one exit point, and that should be the last statement in the method	77
A method should have only one exit point, and that should be the last statement in the method	80
The method 'equals' has a Cyclomatic Complexity of 12.	94 - 107
Avoid variables with short names like o	94
Avoid using if statements without curly braces	95
A method should have only one exit point, and that should be the last statement in the method	95
These nested if statements could be combined	99 - 103
These nested if statements could be combined	100 - 102
A method should have only one exit point, and that should be the last statement in the method	101
Avoid variables with short names like sb	118
A method should have only one exit point, and that should be the last statement in the method	120

org/musicontroller/core/Contract_SK.java

Violation	Line
Avoid variables with short names like id	4
Assigning an Object to null is a code smell. Consider refactoring.	10
Assigning an Object to null is a code smell. Consider refactoring.	11
Avoid variables with short names like id	17

org/musicontroller/core/Event.java

Violation	Line
The class 'Event' has a Cyclomatic Complexity of 2 (Highest = 11).	7 - 151
Avoid variables with short names like id	8
Variables that are final and static should be in all caps.	15
Variables that are final and static should be in all caps.	16
Variables that are final and static should be in all caps.	17
Variables that are final and static should be in all caps.	18
Variables that are final and static should be in all caps.	19
Assigning an Object to null is a code smell. Consider refactoring.	23
Assigning an Object to null is a code smell. Consider refactoring.	25
A method should have only one exit point, and that should be the last statement in the method	44
A method should have only one exit point, and that should be the last statement in the method	45
A method should have only one exit point, and that should be the last statement in the method	46
A method should have only one exit point, and that should be the last statement in the method	47
Avoid variables with short names like id	63
Avoid variables with short names like ev	99
A method should have only one exit point, and that should be the last statement in the method	102
A method should have only one exit point, and that should be the last statement in the method	104
A method should have only one exit point, and that should be the last statement in the method	109
A method should have only one exit point, and that should be the last statement in the method	111
A method should have only one exit point, and that should be the last statement in the method	115
A method should have only one exit point, and that should be the last statement in the method	118
The method 'equals' has a Cyclomatic Complexity of 11.	130 - 141
Avoid variables with short names like o	130
Avoid using if statements without curly braces	131
A method should have only one exit point, and that should be the last statement in the method	131
These nested if statements could be combined	135 - 137
A method should have only one exit point, and that should be the last statement in the method	136

org/musicontroller/core/EventCountLookup.java

Violation	Line
The field name indicates a constant but its modifiers do not	26
Avoid excessively long variable names like _perUserLookupTable	27
Private field '_perUserLookupTable' could be made final; it is only initialized in the declaration or constructor.	27
The class 'InternalLookup' has a Cyclomatic Complexity of 6 (Highest = 13).	33 - 93
Use explicit scoping instead of the default package private level	34
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	34
Use explicit scoping instead of the default package private level	35
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	35
Use explicit scoping instead of the default package private level	36
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	36
Use explicit scoping instead of the default package private level	37
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	37
Use explicit scoping instead of the default package private level	38
Avoid excessively long variable names like _playCountLastYear	38
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	38
Use explicit scoping instead of the default package private level	39
Avoid excessively long variable names like _skipCountLastYear	39
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	39
Use explicit scoping instead of the default package private level	40
Avoid excessively long variable names like _downloadCountLastYear	40
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	40
Use explicit scoping instead of the default package private level	41
Avoid excessively long variable names like _requestCountLastYear	41
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	41
Use explicit scoping instead of the default package private level	42
Overridable method 'addEvent' called during object construction	51
Overridable method 'addEvent' called during object construction	61
The method 'addEvent' has a Cyclomatic Complexity of 13.	68 - 92
An empty statement (semicolon) not part of a loop	80
An empty statement (semicolon) not part of a loop	89
Avoid unused constructor parameters such as 'songid'	99 - 121
These nested if statements could be combined	112 - 117
Deeply nested if..then statements are hard to read	112 - 117
A method should have only one exit point, and that should be the last statement in the method	141
A method should have only one exit point, and that should be the last statement in the method	170
A method should have only one exit point, and that should be the last statement in the method	173
A method should have only one exit point, and that should be the last statement in the method	174
A method should have only one exit point, and that should be the last statement in the method	175
A method should have only one exit point, and that should be the last statement in the method	176
A method should have only one exit point, and that should be the last statement in the method	191
A method should have only one exit point, and that should be the last statement in the method	194
A method should have only one exit point, and that should be the last statement in the method	195
A method should have only one exit point, and that should be the last statement in the method	196
A method should have only one exit point, and that should be the last statement in the method	197
A method should have only one exit point, and that should be the last statement in the method	211

org/musicontroller/core/Eventkind.java

Violation	Line
Avoid variables with short names like id	6
Avoid variables with short names like id	28

org/musicontroller/core/Instrument.java

Violation	Line
Each class should declare at least one constructor	4 - 54
A method should have only one exit point, and that should be the last statement in the method	16

org/musicontroller/core/Keyword.java

Violation	Line
Avoid excessively long variable names like _maxSimilarityPower	19
Variables that are final and static should be in all caps.	19
Variables that are final and static should be in all caps.	20
It is a good practice to call super() in a constructor	22 - 25
Assigning an Object to null is a code smell. Consider refactoring.	23
Assigning an Object to null is a code smell. Consider refactoring.	24
Avoid variables with short names like me	34
Avoid variables with short names like me	46
Avoid empty catch blocks	50 - 52
A method should have only one exit point, and that should be the last statement in the method	76
A method should have only one exit point, and that should be the last statement in the method	79
A method should have only one exit point, and that should be the last statement in the method	82
A method should have only one exit point, and that should be the last statement in the method	85
A method should have only one exit point, and that should be the last statement in the method	97
A method should have only one exit point, and that should be the last statement in the method	106
A method should have only one exit point, and that should be the last statement in the method	148
Avoid excessively long variable names like commonAncestorFound	150
Avoid variables with short names like sb	153
Consider simply returning the value vs storing it in local variable 'similarity'	191
Avoid excessively long variable names like commonAncestorFound	204
A method should have only one exit point, and that should be the last statement in the method	206
Avoid excessively long variable names like remainingSimilarityPower	208
Avoid excessively long variable names like specialisationPenalty	209
Avoid variables with short names like l	230
Avoid variables with short names like p	233
Avoid using if statements without curly braces	263
A method should have only one exit point, and that should be the last statement in the method	263
Avoid using if statements without curly braces	264
A method should have only one exit point, and that should be the last statement in the method	264
Avoid using if statements without curly braces	306
A method should have only one exit point, and that should be the last statement in the method	306

org/musicontroller/core/KeywordCycleException.java

Violation	Line
Each class should declare at least one constructor	10 - 14

org/musicontroller/core/Keywordbag.java

Violation	Line
Avoid variables with short names like id	13
Avoid variables with short names like id	35
A method should have only one exit point, and that should be the last statement in the method	46
A method should have only one exit point, and that should be the last statement in the method	52
Avoid variables with short names like sb	76
Avoid if (x != y) ..; else ..;	79 - 83
Avoid appending characters as strings in StringBuffer.append	80

org/musicontroller/core/Link.java

Violation	Line
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	9
Avoid variables with short names like id	37

org/musicontroller/core/LinkableAbs.java

Violation	Line
Abstract classes should be named AbstractXXX	12 - 116
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	13
Assigning an Object to null is a code smell. Consider refactoring.	23
Avoid variables with short names like id	37
Avoid reassigning parameters such as 'name'	56
A method should have only one exit point, and that should be the last statement in the method	58
A method should have only one exit point, and that should be the last statement in the method	62

org/musicontroller/core/MusicDirProvider.java

Violation	Line
Avoid modifiers which are implied by the context	15

org/musicontroller/core/Playlist.java

Violation	Line
It is a good practice to call super() in a constructor	17 - 24
Assigning an Object to null is a code smell. Consider refactoring.	19
Assigning an Object to null is a code smell. Consider refactoring.	21
Assigning an Object to null is a code smell. Consider refactoring.	22
Assigning an Object to null is a code smell. Consider refactoring.	23
Avoid reassigning parameters such as 'index'	33
A method should have only one exit point, and that should be the last statement in the method	35
Avoid variables with short names like i	38
Avoid variables with short names like c	40
Avoid variables with short names like i	50
Avoid variables with short names like c	52
Deeply nested if..then statements are hard to read	55 - 57
A method should have only one exit point, and that should be the last statement in the method	91
Avoid variables with short names like df	94
Avoid using if statements without curly braces	110
Avoid using if statements without curly braces	157
A method should have only one exit point, and that should be the last statement in the method	157
Avoid variables with short names like i	172
A method should have only one exit point, and that should be the last statement in the method	175
Avoid variables with short names like o	197
Avoid variables with short names like p	199
A method should have only one exit point, and that should be the last statement in the method	200
A method should have only one exit point, and that should be the last statement in the method	230
Avoid variables with short names like sb	242

org/musicontroller/core/Role.java

Violation	Line
Position literals first in String comparisons	29

org/musicontroller/core/Song.java

Violation	Line
This class has a bunch of public methods and attributes	1 - 415
The class 'Song' has a Cyclomatic Complexity of 2 (Highest = 18).	14 - 415
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	16
It is a good practice to call super() in a constructor	26 - 38
Assigning an Object to null is a code smell. Consider refactoring.	30
Assigning an Object to null is a code smell. Consider refactoring.	31
Assigning an Object to null is a code smell. Consider refactoring.	32
Assigning an Object to null is a code smell. Consider refactoring.	33
Assigning an Object to null is a code smell. Consider refactoring.	34
Assigning an Object to null is a code smell. Consider refactoring.	35
Avoid using if statements without curly braces	41
Avoid empty catch blocks	136 - 138
Avoid using if statements without curly braces	201
A method should have only one exit point, and that should be the last statement in the method	213
Avoid variables with short names like pl	224
Avoid variables with short names like L	233
Avoid variables with short names like M	234
Avoid variables with short names like S	235
The method 'getEventCount' has a Cyclomatic Complexity of 18.	306 - 341
Avoid using if statements without curly braces	307
A method should have only one exit point, and that should be the last statement in the method	307
A method should have only one exit point, and that should be the last statement in the method	310
These nested if statements could be combined	313 - 315
A method should have only one exit point, and that should be the last statement in the method	314
These nested if statements could be combined	323 - 337
Avoid using if statements without curly braces	328
Avoid using if statements without curly braces	332
Avoid using if statements without curly braces	334
Avoid using if statements without curly braces	349
A method should have only one exit point, and that should be the last statement in the method	349
Avoid variables with short names like o	362
Avoid using if statements without curly braces	363
A method should have only one exit point, and that should be the last statement in the method	363
A method should have only one exit point, and that should be the last statement in the method	367
Avoid variables with short names like sb	388

org/musicontroller/core/jobs/ConsistencyCheckJob.java

Violation	Line
Each class should declare at least one constructor	9 - 44
Avoid excessively long variable names like nonExistingLinkIDs	21

org/musicontroller/core/jobs/ImportJob.java

Violation	Line
Each class should declare at least one constructor	24 - 111
Avoid excessively long variable names like READY_FOR_INSPECTION	26
Avoid variables with short names like in	36
Use block level rather than method level synchronization	36 - 39
Avoid variables with short names like sb	64
Avoid throwing raw exception types	84
When doing a String.toLowerCase()/toUpperCase() call, use a Locale	86
Avoid throwing raw exception types	100

org/musicontroller/core/jobs/IndexJob.java

Violation	Line
Each class should declare at least one constructor	14 - 57

org/musicontroller/core/jobs/MetadataExtractJob.java

Violation	Line
The class 'MetadataExtractJob' has a Cyclomatic Complexity of 5 (Highest = 14).	42 - 453
Use block level rather than method level synchronization	56 - 58
Use block level rather than method level synchronization	69 - 85
Avoid using if statements without curly braces	70
Deeply nested if..then statements are hard to read	78 - 81
A method should have only one exit point, and that should be the last statement in the method	97
A method should have only one exit point, and that should be the last statement in the method	108
Use block level rather than method level synchronization	113 - 115
Use block level rather than method level synchronization	129 - 149
Avoid variables with short names like in	136
Avoid variables with short names like fn	162
Deeply nested if..then statements are hard to read	178 - 184
Avoid excessively long variable names like forbiddenCharacters	250
A method should have only one exit point, and that should be the last statement in the method	306
The method 'inspectEntry' has a Cyclomatic Complexity of 14.	331 - 394
These nested if statements could be combined	343 - 349
Avoid reassigning parameters such as 'str'	396
Avoid reassigning parameters such as 'str'	396
A method should have only one exit point, and that should be the last statement in the method	399
Perhaps '_CHAR_MAP' could be replaced by a local variable.	415 - 425
Use block level rather than method level synchronization	432 - 450
A method should have only one exit point, and that should be the last statement in the method	435
A method should have only one exit point, and that should be the last statement in the method	442

org/musicontroller/core/jobs/PodcastUpdateJob.java

Violation	Line
The class 'PodcastUpdateJob' has a Cyclomatic Complexity of 4 (Highest = 12).	44 - 205
Each class should declare at least one constructor	44 - 205
A method should have only one exit point, and that should be the last statement in the method	66
Avoid variables with short names like tx	76
Avoid printStackTrace(); use a logger call instead.	102
The method 'updatePodcastPlaylist' has a Cyclomatic Complexity of 12.	123 - 188
Avoid variables with short names like in	138
The String literal "Error importing song " appears 4 times in this file; the first occurrence is on line 165	165

org/musicontroller/core/jobs/ReviewRefreshJob.java

Violation	Line
Each class should declare at least one constructor	26 - 100
Avoid variables with short names like id	66

org/musicontroller/core/searching/ISearcher.java

Violation	Line
Avoid modifiers which are implied by the context	24

org/musicontroller/core/searching/Indexer.java

Violation	Line
The class 'Indexer' has a Cyclomatic Complexity of 3 (Highest = 12).	53 - 534
Private field 'dao' could be made final; it is only initialized in the declaration or constructor.	64
Private field '_reviewService' could be made final; it is only initialized in the declaration or constructor.	65
Assigning an Object to null is a code smell. Consider refactoring.	105
Use block level rather than method level synchronization	112 - 130
The String literal "unchecked" appears 6 times in this file; the first occurrence is on line 136	136
Avoid variables with short names like it	138
Avoid variables with short names like it	157
Avoid variables with short names like it	175
Avoid variables with short names like it	193
Avoid variables with short names like it	211
Avoid variables with short names like it	229
The method 'reindexSong' has a Cyclomatic Complexity of 12.	242 - 306
Avoid variables with short names like id	243
Avoid variables with short names like sb	248
Avoid variables with short names like c	271
Avoid variables with short names like i	280
The String literal "contents" appears 4 times in this file; the first occurrence is on line 299	299
Avoid variables with short names like id	311
Avoid variables with short names like sb	317
Avoid variables with short names like id	340
Avoid variables with short names like id	352
Avoid variables with short names like id	364
Avoid variables with short names like id	378
Avoid variables with short names like sb	383
The String literal "uniqueid" appears 5 times in this file; the first occurrence is on line 415	415
A method should have only one exit point, and that should be the last statement in the method	444
Assigning an Object to null is a code smell. Consider refactoring.	473

org/musicontroller/core/searching/Item.java

Violation	Line
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	11
Private field '_id' could be made final; it is only initialized in the declaration or constructor.	11
Private field '_name' could be made final; it is only initialized in the declaration or constructor.	12
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	14
Private field '_score' could be made final; it is only initialized in the declaration or constructor.	14
Private field '_excerpt' could be made final; it is only initialized in the declaration or constructor.	15
Avoid variables with short names like id	17

org/musicontroller/core/searching/MCSearcher.java

Violation	Line
Each class should declare at least one constructor	31 - 116
System.out.print is used	45
System.out.print is used	46
Avoid variables with short names like s	49
Avoid empty catch blocks	56 - 57
Avoid empty catch blocks	57 - 58
When doing a String.toLowerCase()/toUpperCase() call, use a Locale	76
Avoid variables with short names like id	86
When doing a String.toLowerCase()/toUpperCase() call, use a Locale	101
When doing a String.toLowerCase()/toUpperCase() call, use a Locale	102
Avoid using if statements without curly braces	108
Avoid using if statements without curly braces	109
A method should have only one exit point, and that should be the last statement in the method	111

org/musicontroller/dao/BagAndKeywordUtils.java

Violation	Line
The class 'BagAndKeywordUtils' has a Cyclomatic Complexity of 5 (Highest = 13).	34 - 541
Each class should declare at least one constructor	34 - 541
A method should have only one exit point, and that should be the last statement in the method	55
A method should have only one exit point, and that should be the last statement in the method	58
Avoid variables with short names like i	61
These nested if statements could be combined	65 - 69
These nested if statements could be combined	66 - 68
Deeply nested if..then statements are hard to read	66 - 68
A method should have only one exit point, and that should be the last statement in the method	67
A method should have only one exit point, and that should be the last statement in the method	91
A method should have only one exit point, and that should be the last statement in the method	94
Avoid variables with short names like i	100
These nested if statements could be combined	104 - 108
These nested if statements could be combined	105 - 107
Deeply nested if..then statements are hard to read	105 - 107
A method should have only one exit point, and that should be the last statement in the method	106
Avoid variables with short names like kw	128
A method should have only one exit point, and that should be the last statement in the method	153
Avoid variables with short names like kw	155
Avoid empty catch blocks	161 - 163
Avoid reassigning parameters such as 'keywords'	188
Avoid excessively long variable names like remaining_candidates	234
Avoid excessively long variable names like bag_currentRelation	236
The method 'buildAiRelationBeanList' has a Cyclomatic Complexity of 13.	372 - 442
A method should have only one exit point, and that should be the last statement in the method	375
Avoid excessively long variable names like instrumentsOfThisTrackList	424
Avoid variables with short names like sb	425
Avoid reassigning parameters such as 'artistfirstname'	514
Avoid reassigning parameters such as 'artistlastname'	514

org/musicontroller/dao/Dao.java

Violation	Line
This class has a bunch of public methods and attributes	1 - 459
Avoid modifiers which are implied by the context	23
Avoid modifiers which are implied by the context	30
Avoid variables with short names like id	30
Avoid modifiers which are implied by the context	38
Avoid modifiers which are implied by the context	46
Avoid variables with short names like id	46
Avoid modifiers which are implied by the context	55
Avoid modifiers which are implied by the context	62
Avoid variables with short names like id	62
Avoid modifiers which are implied by the context	69
Avoid variables with short names like id	69
Avoid modifiers which are implied by the context	76
Avoid variables with short names like id	76
Avoid modifiers which are implied by the context	83
Avoid variables with short names like id	83
Avoid modifiers which are implied by the context	90
Avoid variables with short names like id	90
Avoid modifiers which are implied by the context	98
Avoid modifiers which are implied by the context	107
Avoid modifiers which are implied by the context	109
Avoid modifiers which are implied by the context	110
Avoid modifiers which are implied by the context	124
Avoid modifiers which are implied by the context	125
Avoid modifiers which are implied by the context	126
Avoid modifiers which are implied by the context	137
Avoid modifiers which are implied by the context	144
Avoid modifiers which are implied by the context	151
Avoid modifiers which are implied by the context	161
Avoid modifiers which are implied by the context	172
Avoid modifiers which are implied by the context	182
Avoid modifiers which are implied by the context	190
Avoid modifiers which are implied by the context	197
Avoid modifiers which are implied by the context	206
Avoid modifiers which are implied by the context	215
Avoid modifiers which are implied by the context	223
Avoid modifiers which are implied by the context	229
Avoid modifiers which are implied by the context	235
Avoid modifiers which are implied by the context	241
Avoid modifiers which are implied by the context	247
Avoid modifiers which are implied by the context	253
Avoid modifiers which are implied by the context	259
Avoid modifiers which are implied by the context	265
Avoid modifiers which are implied by the context	271
Avoid modifiers which are implied by the context	277
Avoid modifiers which are implied by the context	287
Avoid modifiers which are implied by the context	294
Avoid modifiers which are implied by the context	301
Avoid modifiers which are implied by the context	302
Avoid modifiers which are implied by the context	308
Avoid modifiers which are implied by the context	314
Avoid modifiers which are implied by the context	316
Avoid modifiers which are implied by the context	317
Avoid variables with short names like o	317
Avoid modifiers which are implied by the context	326
Avoid modifiers which are implied by the context	332
Avoid modifiers which are implied by the context	343
Avoid modifiers which are implied by the context	352
Avoid modifiers which are implied by the context	358
Avoid modifiers which are implied by the context	365
Avoid modifiers which are implied by the context	383
Avoid modifiers which are implied by the context	391
Avoid modifiers which are implied by the context	397
Avoid modifiers which are implied by the context	405
Avoid modifiers which are implied by the context	407
A signature (constructor or method) shouldn't have Exception in throws declaration	407
Avoid modifiers which are implied by the context	416
Avoid modifiers which are implied by the context	422
Avoid modifiers which are implied by the context	431
Avoid modifiers which are implied by the context	437
Avoid modifiers which are implied by the context	443
Avoid modifiers which are implied by the context	449
Avoid modifiers which are implied by the context	456
Avoid modifiers which are implied by the context	458

org/musicontroller/dao/HibernateDao.java

Violation	Line
This class has a bunch of public methods and attributes	1 - 1295
Avoid unused imports such as 'org.varienaja.util.FileOperations'	49
Avoid really long classes.	51 - 1295
The class 'HibernateDao' has a Cyclomatic Complexity of 2 (Highest = 20).	51 - 1295
Avoid excessively long variable names like _songChangeListeners	54
Private field '_songChangeListeners' could be made final; it is only initialized in the declaration or constructor.	54
It is a good practice to call super() in a constructor	56 - 58
The String literal "unchecked" appears 43 times in this file; the first occurrence is on line 60	60
Avoid variables with short names like id	66
Avoid variables with short names like id	80
The String literal "name" appears 8 times in this file; the first occurrence is on line 92	92
When doing a String.toLowerCase()/toUpperCase() call, use a Locale	93
Avoid variables with short names like id	97
Avoid variables with short names like id	101
Avoid variables with short names like id	105
Avoid variables with short names like id	109
A method should have only one exit point, and that should be the last statement in the method	116
Avoid variables with short names like sb	118
When doing a String.toLowerCase()/toUpperCase() call, use a Locale	125
When doing a String.toLowerCase()/toUpperCase() call, use a Locale	130
When doing a String.toLowerCase()/toUpperCase() call, use a Locale	130
Assigning an Object to null is a code smell. Consider refactoring.	147
Avoid variables with short names like id	150
Avoid variables with short names like l	171
Avoid variables with short names like q	199
Avoid printStackTrace(); use a logger call instead.	205
A signature (constructor or method) shouldn't have Exception in throws declaration	220
Avoid using if statements without curly braces	227 - 228
Avoid using if statements without curly braces	229 - 230
Avoid variables with short names like s	235
Avoid throwing raw exception types	251
A method should have only one exit point, and that should be the last statement in the method	269
Avoid variables with short names like sb	374
The String literal "user" appears 5 times in this file; the first occurrence is on line 381	381
Avoid variables with short names like it	397
Avoid variables with short names like l	409
Avoid variables with short names like l	431
Avoid reassigning parameters such as 'title'	449
Avoid variables with short names like s	463
Avoid variables with short names like sb	488
Avoid variables with short names like l	502
Avoid variables with short names like id	527
A method should have only one exit point, and that should be the last statement in the method	530
The method 'getSpecialPlaylist' has a Cyclomatic Complexity of 20.	536 - 592
Avoid reassigning parameters such as 'kind'	536
Avoid using if statements without curly braces	537
A switch statement does not contain a break	554 - 591
A method should have only one exit point, and that should be the last statement in the method	555
A method should have only one exit point, and that should be the last statement in the method	556
A method should have only one exit point, and that should be the last statement in the method	557
A method should have only one exit point, and that should be the last statement in the method	558
A method should have only one exit point, and that should be the last statement in the method	559
A method should have only one exit point, and that should be the last statement in the method	560
A method should have only one exit point, and that should be the last statement in the method	561
A method should have only one exit point, and that should be the last statement in the method	576
A method should have only one exit point, and that should be the last statement in the method	580
A method should have only one exit point, and that should be the last statement in the method	581
A method should have only one exit point, and that should be the last statement in the method	582
A method should have only one exit point, and that should be the last statement in the method	583
A method should have only one exit point, and that should be the last statement in the method	584
A method should have only one exit point, and that should be the last statement in the method	585
A method should have only one exit point, and that should be the last statement in the method	586
A method should have only one exit point, and that should be the last statement in the method	588
A method should have only one exit point, and that should be the last statement in the method	589
Avoid using if statements without curly braces	617
Avoid variables with short names like s	636
A method should have only one exit point, and that should be the last statement in the method	650
A method should have only one exit point, and that should be the last statement in the method	672
Avoid variables with short names like l	682
Assigning an Object to null is a code smell. Consider refactoring.	685
Avoid variables with short names like o	757
Avoid variables with short names like sb	764
StringBuffer constructor is initialized with size 16, but has at least 272 characters appended	764
StringBuffer.append is called 2 consecutive times with literal Strings. Use a single append with a single String.	765
StringBuffer.append is called 3 consecutive times with literal Strings. Use a single append with a single String.	766
StringBuffer.append is called 2 consecutive times with literal Strings. Use a single append with a single String.	774
Avoid variables with short names like sb	813
A method should have only one exit point, and that should be the last statement in the method	826
Avoid variables with short names like it	829
Avoid using if statements without curly braces	853
A method should have only one exit point, and that should be the last statement in the method	853
Avoid using if statements without curly braces	854
A method should have only one exit point, and that should be the last statement in the method	854
Avoid variables with short names like sb	858
Avoid variables with short names like it	866
Avoid variables with short names like kw	870
A method should have only one exit point, and that should be the last statement in the method	882
Avoid unused method parameters such as 'user'	916 - 944
Avoid variables with short names like sb	926
Avoid variables with short names like l	934
Avoid variables with short names like sb	990
Avoid variables with short names like l	1010
Avoid variables with short names like sb	1028
Avoid variables with short names like l	1033
The method 'mergeSongs' has a Cyclomatic Complexity of 11.	1056 - 1103
These nested if statements could be combined	1085 - 1089
These nested if statements could be combined	1086 - 1088
These nested if statements could be combined	1097 - 1099
Avoid variables with short names like sb	1108
A signature (constructor or method) shouldn't have Exception in throws declaration	1137
Consider simply returning the value vs storing it in local variable 'result'	1140
A method should have only one exit point, and that should be the last statement in the method	1203

org/musicontroller/dao/PlaylistKey.java

Violation	Line
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	31
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	32
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	33
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	34
Avoid variables with short names like id	36
Assigning an Object to null is a code smell. Consider refactoring.	38
Assigning an Object to null is a code smell. Consider refactoring.	39
Avoid variables with short names like g	53
Avoid variables with short names like id	64
A method should have only one exit point, and that should be the last statement in the method	91
A method should have only one exit point, and that should be the last statement in the method	111

org/musicontroller/gui/ArtistInfo.java

Violation	Line
Avoid unused imports such as 'org.apache.log4j.Logger'	5
Abstract classes should be named AbstractXXX	20 - 71
Avoid variables with short names like id	24
Avoid variables with short names like e	36
Assigning an Object to null is a code smell. Consider refactoring.	37
Avoid variables with short names like e	44
Assigning an Object to null is a code smell. Consider refactoring.	45

org/musicontroller/gui/BandInfo.java

Violation	Line
Each class should declare at least one constructor	14 - 54
Abstract classes should be named AbstractXXX	14 - 54
Avoid variables with short names like id	16
Avoid variables with short names like ev	51
Assigning an Object to null is a code smell. Consider refactoring.	52

org/musicontroller/gui/Bands.java

Violation	Line
Each class should declare at least one constructor	9 - 55
Abstract classes should be named AbstractXXX	9 - 55
Avoid using if statements without curly braces	46
Avoid using if statements without curly braces	47
Avoid using if statements without curly braces	48
Avoid using if statements without curly braces	49
Avoid using if statements without curly braces	50

org/musicontroller/gui/Home.java

Violation	Line
Each class should declare at least one constructor	13 - 39
Abstract classes should be named AbstractXXX	13 - 39

org/musicontroller/gui/Keywords.java

Violation	Line
Each class should declare at least one constructor	16 - 115
Abstract classes should be named AbstractXXX	16 - 115
Avoid variables with short names like ev	48
Assigning an Object to null is a code smell. Consider refactoring.	49
Avoid using if statements without curly braces	84
Avoid using if statements without curly braces	85
Avoid using if statements without curly braces	86
Avoid using if statements without curly braces	87
Avoid using if statements without curly braces	88

org/musicontroller/gui/Logon.java

Violation	Line
Each class should declare at least one constructor	13 - 25
Abstract classes should be named AbstractXXX	13 - 25
Avoid variables with short names like ev	21

org/musicontroller/gui/MyAccount.java

Violation	Line
Each class should declare at least one constructor	15 - 76
Abstract classes should be named AbstractXXX	15 - 76
A method should have only one exit point, and that should be the last statement in the method	28
Avoid variables with short names like dj	30
A method should have only one exit point, and that should be the last statement in the method	32
A method should have only one exit point, and that should be the last statement in the method	35
A method should have only one exit point, and that should be the last statement in the method	49
Avoid variables with short names like dj	51
A method should have only one exit point, and that should be the last statement in the method	67
Avoid variables with short names like dj	69

org/musicontroller/gui/NextToFieldErrorDisplayDelegate.java

Violation	Line
Each class should declare at least one constructor	15 - 57
Avoid variables with short names like ft	34
Avoid using if statements without curly braces	40 - 41

org/musicontroller/gui/PlaylistInfo.java

Violation	Line
Abstract classes should be named AbstractXXX	17 - 149
Avoid variables with short names like id	19
Avoid variables with short names like id	21
Avoid variables with short names like e	32
Assigning an Object to null is a code smell. Consider refactoring.	33
Avoid variables with short names like e	40
Assigning an Object to null is a code smell. Consider refactoring.	41
Perhaps '_dateFormat' could be replaced by a local variable.	64
When instantiating a SimpleDateFormat object, specify a Locale	68
Avoid variables with short names like o	96
Avoid using if statements without curly braces	97
A method should have only one exit point, and that should be the last statement in the method	97
Avoid variables with short names like i	99
A method should have only one exit point, and that should be the last statement in the method	100
A method should have only one exit point, and that should be the last statement in the method	103
A method should have only one exit point, and that should be the last statement in the method	137
A method should have only one exit point, and that should be the last statement in the method	144

org/musicontroller/gui/Podcasts.java

Violation	Line
Each class should declare at least one constructor	11 - 25
Abstract classes should be named AbstractXXX	11 - 25
Avoid excessively long variable names like podcastImportThread	21

org/musicontroller/gui/Search.java

Violation	Line
The class 'Search' has a Cyclomatic Complexity of 2 (Highest = 11).	26 - 145
Each class should declare at least one constructor	26 - 145
Abstract classes should be named AbstractXXX	26 - 145
The method 'setItem' has a Cyclomatic Complexity of 11.	105 - 143

org/musicontroller/gui/SongInfo.java

Violation	Line
Abstract classes should be named AbstractXXX	23 - 155
Avoid variables with short names like id	27
Avoid variables with short names like br	30
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	36
Avoid variables with short names like e	44
Assigning an Object to null is a code smell. Consider refactoring.	45
Assigning an Object to null is a code smell. Consider refactoring.	46
Avoid variables with short names like e	53
Assigning an Object to null is a code smell. Consider refactoring.	54
Assigning an Object to null is a code smell. Consider refactoring.	55

org/musicontroller/gui/Welcome.java

Violation	Line
Each class should declare at least one constructor	18 - 54
Abstract classes should be named AbstractXXX	18 - 54
Avoid variables with short names like ev	23
Avoid variables with short names like sc	28

org/musicontroller/gui/admin/Adduser.java

Violation	Line
Each class should declare at least one constructor	20 - 108
Abstract classes should be named AbstractXXX	20 - 108
A method should have only one exit point, and that should be the last statement in the method	38
A method should have only one exit point, and that should be the last statement in the method	41
Avoid if (x != y) ..; else ..;	78 - 82

org/musicontroller/gui/admin/DoubleSongs.java

Violation	Line
Each class should declare at least one constructor	12 - 61
Abstract classes should be named AbstractXXX	12 - 61
Returning '_pair' may expose an internal array	22
The user-supplied array 'pair' is stored directly	25

org/musicontroller/gui/admin/Keywordmanagement.java

Violation	Line
Abstract classes should be named AbstractXXX	18 - 182
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	22
Avoid variables with short names like e	34
Assigning an Object to null is a code smell. Consider refactoring.	35
Avoid variables with short names like e	42
Assigning an Object to null is a code smell. Consider refactoring.	43
Returning '_matrix' may expose an internal array	64
Avoid variables with short names like x	67
Avoid variables with short names like k	92
A method should have only one exit point, and that should be the last statement in the method	176

org/musicontroller/gui/admin/RoleSelectionModel.java

Violation	Line
Private field '_itemList' could be made final; it is only initialized in the declaration or constructor.	15

org/musicontroller/gui/admin/Usermanagement.java

Violation	Line
Each class should declare at least one constructor	20 - 67
Abstract classes should be named AbstractXXX	20 - 67
Avoid variables with short names like sb	41
Avoid variables with short names like d	62

org/musicontroller/gui/components/AIList.java

Violation	Line
Each class should declare at least one constructor	15 - 27
Abstract classes should be named AbstractXXX	15 - 27

org/musicontroller/gui/components/ArtistLink.java

Violation	Line
Each class should declare at least one constructor	12 - 27
Abstract classes should be named AbstractXXX	12 - 27

org/musicontroller/gui/components/BandLink.java

Violation	Line
Each class should declare at least one constructor	14 - 29
Abstract classes should be named AbstractXXX	14 - 29

org/musicontroller/gui/components/Border.java

Violation	Line
Each class should declare at least one constructor	24 - 143
Abstract classes should be named AbstractXXX	24 - 143
Avoid reassigning parameters such as 'songid'	40
A method should have only one exit point, and that should be the last statement in the method	44
Avoid variables with short names like dj	46
A method should have only one exit point, and that should be the last statement in the method	73
Avoid variables with short names like dj	75
Avoid variables with short names like sc	105
This statement may have some unnecessary parentheses	132
This statement may have some unnecessary parentheses	140

org/musicontroller/gui/components/CoverArt.java

Violation	Line
Each class should declare at least one constructor	13 - 31
Abstract classes should be named AbstractXXX	13 - 31
Avoid variables with short names like id	15
Avoid variables with short names like id	17

org/musicontroller/gui/components/CurrentlyPlaying.java

Violation	Line
Each class should declare at least one constructor	16 - 60
Abstract classes should be named AbstractXXX	16 - 60
A method should have only one exit point, and that should be the last statement in the method	25
Avoid variables with short names like dj	31
Avoid variables with short names like dj	41
Avoid variables with short names like dj	50
A method should have only one exit point, and that should be the last statement in the method	54

org/musicontroller/gui/components/EditLink.java

Violation	Line
Each class should declare at least one constructor	24 - 56
Abstract classes should be named AbstractXXX	24 - 56

org/musicontroller/gui/components/EventList.java

Violation	Line
Each class should declare at least one constructor	13 - 33
Abstract classes should be named AbstractXXX	13 - 33

org/musicontroller/gui/components/InstrumentLink.java

Violation	Line
Each class should declare at least one constructor	12 - 16
Abstract classes should be named AbstractXXX	12 - 16

org/musicontroller/gui/components/KeywordLink.java

Violation	Line
Each class should declare at least one constructor	15 - 36
Abstract classes should be named AbstractXXX	15 - 36

org/musicontroller/gui/components/KeywordList.java

Violation	Line
Each class should declare at least one constructor	11 - 19
Abstract classes should be named AbstractXXX	11 - 19

org/musicontroller/gui/components/PlaylistLink.java

Violation	Line
Each class should declare at least one constructor	15 - 56
Abstract classes should be named AbstractXXX	15 - 56
Avoid if (x != y) ..; else ..;	37 - 41
A method should have only one exit point, and that should be the last statement in the method	38
Avoid if (x != y) ..; else ..;	49 - 53
A method should have only one exit point, and that should be the last statement in the method	50

org/musicontroller/gui/components/PlaylistList.java

Violation	Line
Each class should declare at least one constructor	24 - 46
Abstract classes should be named AbstractXXX	24 - 46
A method should have only one exit point, and that should be the last statement in the method	41

org/musicontroller/gui/components/PlaylistRequester.java

Violation	Line
Each class should declare at least one constructor	7 - 18
Abstract classes should be named AbstractXXX	7 - 18

org/musicontroller/gui/components/PlaylistReviews.java

Violation	Line
Each class should declare at least one constructor	13 - 42
Abstract classes should be named AbstractXXX	13 - 42
A method should have only one exit point, and that should be the last statement in the method	30

org/musicontroller/gui/components/SongLink.java

Violation	Line
Each class should declare at least one constructor	14 - 32
Abstract classes should be named AbstractXXX	14 - 32

org/musicontroller/gui/components/SongList.java

Violation	Line
Each class should declare at least one constructor	31 - 110
Abstract classes should be named AbstractXXX	31 - 110
Avoid variables with short names like d	83

org/musicontroller/gui/components/SongRequester.java

Violation	Line
Each class should declare at least one constructor	11 - 30
Abstract classes should be named AbstractXXX	11 - 30

org/musicontroller/gui/components/SuggestInput.java

Violation	Line
Each class should declare at least one constructor	20 - 77
Abstract classes should be named AbstractXXX	20 - 77
Avoid variables with short names like id	22
Avoid using if statements without curly braces	48 - 49
Avoid using if statements without curly braces	66

org/musicontroller/gui/components/Usage.java

Violation	Line
Each class should declare at least one constructor	18 - 144
Abstract classes should be named AbstractXXX	18 - 144
Avoid variables with short names like d	57
Avoid variables with short names like d	62
Avoid variables with short names like d	88
This statement may have some unnecessary parentheses	125
This statement may have some unnecessary parentheses	133
This statement may have some unnecessary parentheses	141

org/musicontroller/gui/dynamic/CurrentlyPlaying.java

Violation	Line
Each class should declare at least one constructor	11 - 13
Abstract classes should be named AbstractXXX	11 - 13
This abstract class does not have any abstract methods	11 - 13

org/musicontroller/gui/dynamic/PodcastEncoder.java

Violation	Line
Each class should declare at least one constructor	8 - 43
Avoid variables with short names like sb	26

org/musicontroller/gui/dynamic/SongDownloadEncoder.java

Violation	Line
Each class should declare at least one constructor	8 - 38
Avoid variables with short names like id	14
Avoid variables with short names like sb	26

org/musicontroller/gui/dynamic/Suggestions.java

Violation	Line
Abstract classes should be named AbstractXXX	19 - 74
Avoid variables with short names like e	34
Assigning an Object to null is a code smell. Consider refactoring.	35
Avoid variables with short names like e	42
Assigning an Object to null is a code smell. Consider refactoring.	43
Avoid unused method parameters such as 'query'	50 - 61

org/musicontroller/gui/edit/AiRelationBean.java

Violation	Line
Avoid variables with short names like o	92
A method should have only one exit point, and that should be the last statement in the method	96 - 99
Avoid variables with short names like o	109
A method should have only one exit point, and that should be the last statement in the method	112
A method should have only one exit point, and that should be the last statement in the method	114
A method should have only one exit point, and that should be the last statement in the method	118
A method should have only one exit point, and that should be the last statement in the method	124
A method should have only one exit point, and that should be the last statement in the method	126
A method should have only one exit point, and that should be the last statement in the method	130
A method should have only one exit point, and that should be the last statement in the method	132

org/musicontroller/gui/edit/BandEdit.java

Violation	Line
Avoid unused imports such as 'org.musicontroller.MusiControllerException'	12
Abstract classes should be named AbstractXXX	22 - 95
Avoid variables with short names like id	26
Avoid variables with short names like e	45
Avoid variables with short names like e	57
Assigning an Object to null is a code smell. Consider refactoring.	58

org/musicontroller/gui/edit/BaseEditPage.java

Violation	Line
Each class should declare at least one constructor	15 - 30
Abstract classes should be named AbstractXXX	15 - 30

org/musicontroller/gui/edit/CoverArtEdit.java

Violation	Line
Each class should declare at least one constructor	49 - 233
Abstract classes should be named AbstractXXX	49 - 233
Avoid variables with short names like id	56
Avoid printStackTrace(); use a logger call instead.	133
Avoid empty catch blocks	138 - 139
Avoid empty catch blocks	144 - 145
A method should have only one exit point, and that should be the last statement in the method	158
A method should have only one exit point, and that should be the last statement in the method	191
Consider simply returning the value vs storing it in local variable 'link'	191
Avoid empty catch blocks	193 - 195
A method should have only one exit point, and that should be the last statement in the method	214
A method should have only one exit point, and that should be the last statement in the method	227

org/musicontroller/gui/edit/PlaylistEdit.java

Violation	Line
Each class should declare at least one constructor	44 - 209
Abstract classes should be named AbstractXXX	44 - 209
Avoid variables with short names like id	47
Assigning an Object to null is a code smell. Consider refactoring.	140
Avoid variables with short names like id	148
Consider simply returning the value vs storing it in local variable 'link'	207

org/musicontroller/gui/edit/PlaylistMergeBean.java

Violation	Line
Each class should declare at least one constructor	11 - 74
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	18
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	29

org/musicontroller/gui/edit/SongBean.java

Violation	Line
Each class should declare at least one constructor	14 - 139
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	18
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	19
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	21
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	23
Avoid variables with short names like id	120

org/musicontroller/gui/edit/SongEdit.java

Violation	Line
Each class should declare at least one constructor	25 - 138
Abstract classes should be named AbstractXXX	25 - 138
Avoid variables with short names like id	29
Avoid variables with short names like e	64
Assigning an Object to null is a code smell. Consider refactoring.	65

org/musicontroller/gui/edit/TrackList.java

Violation	Line
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	25
Private field '_tracks' could be made final; it is only initialized in the declaration or constructor.	30
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	35
A method should have only one exit point, and that should be the last statement in the method	88
A method should have only one exit point, and that should be the last statement in the method	92
A method should have only one exit point, and that should be the last statement in the method	111
Avoid empty catch blocks	187 - 189
Avoid empty catch blocks	197 - 199

org/musicontroller/gui/importer/Import.java

Violation	Line
Each class should declare at least one constructor	17 - 44
Abstract classes should be named AbstractXXX	17 - 44

org/musicontroller/gui/importer/ImportProgress.java

Violation	Line
Each class should declare at least one constructor	18 - 72
Abstract classes should be named AbstractXXX	18 - 72

org/musicontroller/gui/importer/MusicArchive.java

Violation	Line
Each class should declare at least one constructor	65 - 347
Abstract classes should be named AbstractXXX	65 - 347
A method should have only one exit point, and that should be the last statement in the method	149
Avoid excessively long variable names like guessedPlaylistName	153
A method should have only one exit point, and that should be the last statement in the method	168
Avoid if (x != y) ..; else ..;	200 - 210
A method should have only one exit point, and that should be the last statement in the method	203
Consider simply returning the value vs storing it in local variable 'link'	203
Consider simply returning the value vs storing it in local variable 'pageLink'	209

org/musicontroller/gui/importer/ReviewImportedMusic.java

Violation	Line
Each class should declare at least one constructor	10 - 14
Abstract classes should be named AbstractXXX	10 - 14
This abstract class does not have any abstract methods	10 - 14

org/musicontroller/gui/statistics/Bandwidth.java

Violation	Line
Each class should declare at least one constructor	19 - 48
Abstract classes should be named AbstractXXX	19 - 48

org/musicontroller/gui/statistics/Database.java

Violation	Line
Each class should declare at least one constructor	25 - 236
Abstract classes should be named AbstractXXX	25 - 236
A method should have only one exit point, and that should be the last statement in the method	41
A method should have only one exit point, and that should be the last statement in the method	53
A method should have only one exit point, and that should be the last statement in the method	65
A method should have only one exit point, and that should be the last statement in the method	77
A method should have only one exit point, and that should be the last statement in the method	91
A method should have only one exit point, and that should be the last statement in the method	105
A method should have only one exit point, and that should be the last statement in the method	119
Avoid variables with short names like d	134
Avoid variables with short names like d	145
Avoid variables with short names like d	156
This statement may have some unnecessary parentheses	230 - 233

org/musicontroller/importer/Importer.java

Violation	Line
Avoid modifiers which are implied by the context	17

org/musicontroller/importer/ImporterImpl.java

Violation	Line
The class 'ImporterImpl' has a Cyclomatic Complexity of 5 (Highest = 17).	32 - 241
Each class should declare at least one constructor	32 - 241
The Logger variable declaration does not contain the static and final modifiers	37
The method 'importMusic' has a Cyclomatic Complexity of 17.	81 - 130
A method should have only one exit point, and that should be the last statement in the method	150
The method 'importIntoMusiController' has a Cyclomatic Complexity of 12.	174 - 219
Avoid unused method parameters such as 'archive'	174 - 219
Caught exception is rethrown, original stack trace may be lost	215

org/musicontroller/importer/MP3InspectorJID3Lib.java

Violation	Line
Use explicit scoping instead of the default package private level	19
Use explicit scoping instead of the default package private level	20
Use explicit scoping instead of the default package private level	21
Use explicit scoping instead of the default package private level	22
Use explicit scoping instead of the default package private level	23
Use explicit scoping instead of the default package private level	24
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	24
Use explicit scoping instead of the default package private level	25
Caught exception is rethrown, original stack trace may be lost	42
Avoid empty catch blocks	99 - 101
Avoid variables with short names like f	117

org/musicontroller/importer/MediafileInspector.java

Violation	Line
Avoid modifiers which are implied by the context	16
Avoid modifiers which are implied by the context	22
Avoid modifiers which are implied by the context	28
Avoid modifiers which are implied by the context	34
Avoid modifiers which are implied by the context	40
Avoid modifiers which are implied by the context	46
Avoid modifiers which are implied by the context	52
Avoid modifiers which are implied by the context	58
Avoid modifiers which are implied by the context	64
Avoid modifiers which are implied by the context	70

org/musicontroller/importer/MusicArchiveBean.java

Violation	Line
The Logger variable declaration does not contain the static and final modifiers	29
Avoid excessively long variable names like _playlistPropertiesMap	40
Private field '_playlistPropertiesMap' could be made final; it is only initialized in the declaration or constructor.	40
Assigning an Object to null is a code smell. Consider refactoring.	58
Assigning an Object to null is a code smell. Consider refactoring.	59
A method should have only one exit point, and that should be the last statement in the method	69
These nested if statements could be combined	150 - 152
Deeply nested if..then statements are hard to read	150 - 152

org/musicontroller/importer/MusicArchiveEntryBean.java

Violation	Line
Overridable method 'setKeywords' called during object construction	28
Overridable method 'setInclude' called during object construction	29
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	52
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	62
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	67
Avoid variables with short names like o	255
Avoid using if statements without curly braces	256
A method should have only one exit point, and that should be the last statement in the method	256
Avoid variables with short names like b	259
A method should have only one exit point, and that should be the last statement in the method	267
A method should have only one exit point, and that should be the last statement in the method	269
Avoid variables with short names like sb	283
A method should have only one exit point, and that should be the last statement in the method	286
Avoid variables with short names like o	297
Avoid empty if statements	301 - 303
A method should have only one exit point, and that should be the last statement in the method	314
Avoid empty if statements	319 - 321
A method should have only one exit point, and that should be the last statement in the method	331

org/musicontroller/importer/PlaylistImportProperties.java

Violation	Line
Avoid excessively long variable names like _addToExistingPlaylist	27
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	27
Avoid excessively long variable names like _coverArtSearchDone	32
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	32
Avoid excessively long variable names like _timeOfLastCoverArtSearch	37
Avoid excessively long variable names like toExistingPlaylist	62
Avoid excessively long variable names like ofLastCoverArtSearch	142

org/musicontroller/importer/TrackNumberParser.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	1 - 56
Each class should declare at least one constructor	15 - 56
A method should have only one exit point, and that should be the last statement in the method	32
A method should have only one exit point, and that should be the last statement in the method	37
Avoid empty catch blocks	38 - 40
Avoid variables with short names like p	41
Avoid variables with short names like m	42
A method should have only one exit point, and that should be the last statement in the method	47
Avoid empty catch blocks	48 - 51

org/musicontroller/model/Linkable.java

Violation	Line
Avoid modifiers which are implied by the context	8
Avoid modifiers which are implied by the context	9
Avoid modifiers which are implied by the context	10

org/musicontroller/repair/ConsistencyChecker.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	1 - 53
Avoid unused imports such as 'java.io.File'	3
Each class should declare at least one constructor	12 - 53
Use block level rather than method level synchronization	22 - 44

org/musicontroller/repair/MergeAiRelations.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	1 - 24
Each class should declare at least one constructor	11 - 24

org/musicontroller/repair/MergeArtistCopies.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	1 - 84
Each class should declare at least one constructor	21 - 84

org/musicontroller/repair/RemoveUnusedAiBags.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	1 - 42
Each class should declare at least one constructor	16 - 42
Avoid variables with short names like it	28

org/musicontroller/repair/SongLengthRepair.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	1 - 63
Each class should declare at least one constructor	22 - 63
The Logger variable declaration does not contain the static and final modifiers	23
The String literal "Song " appears 5 times in this file; the first occurrence is on line 36	36

org/musicontroller/rss/MetadataProvider.java

Violation	Line
Avoid modifiers which are implied by the context	18
Avoid modifiers which are implied by the context	25
Avoid modifiers which are implied by the context	32
Avoid modifiers which are implied by the context	39
Avoid modifiers which are implied by the context	46

org/musicontroller/rss/RssDAO.java

Violation	Line
Each class should declare at least one constructor	47 - 483
The field name indicates a constant but its modifiers do not	49
The class 'PodCastRSSHandler' has a Cyclomatic Complexity of 6 (Highest = 21).	63 - 208
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	67
Avoid excessively long variable names like _playlistkeywordsset	68
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	68
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	71
It is a good practice to call super() in a constructor	76 - 85
Assigning an Object to null is a code smell. Consider refactoring.	77
Assigning an Object to null is a code smell. Consider refactoring.	82
Assigning an Object to null is a code smell. Consider refactoring.	83
The method 'endElement' has a Cyclomatic Complexity of 21.	114 - 198
These nested if statements could be combined	130 - 132
These nested if statements could be combined	136 - 139
Deeply nested if..then statements are hard to read	157 - 159
Deeply nested if..then statements are hard to read	161 - 164
Deeply nested if..then statements are hard to read	185 - 189
Deeply nested if..then statements are hard to read	190 - 193
Avoid variables with short names like ch	205
Avoid variables with short names like in	219
Avoid variables with short names like xr	222
A method should have only one exit point, and that should be the last statement in the method	229
Assigning an Object to null is a code smell. Consider refactoring.	235
Avoid variables with short names like in	247
Avoid really long methods.	284 - 390
Avoid variables with short names like tf	293
Avoid variables with short names like hd	294
Avoid variables with short names like t	295
The String literal "CDATA" appears 10 times in this file; the first occurrence is on line 302	302
Avoid using if statements without curly braces	385
Avoid variables with short names like hd	399
Avoid variables with short names like it	427
Assigning an Object to null is a code smell. Consider refactoring.	429
Avoid if (x != y) ..; else ..;	459 - 464

org/musicontroller/security/Authority.java

Violation	Line
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	25
Avoid variables with short names like id	41

org/musicontroller/security/DaoUserDetailsService.java

Violation	Line
Each class should declare at least one constructor	17 - 42
Avoid variables with short names like p	37
Avoid using if statements without curly braces	38

org/musicontroller/security/Encrypter.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	5 - 42
Each class should declare at least one constructor	15 - 42
Avoid reassigning parameters such as 'unencrypted'	22
An empty statement (semicolon) not part of a loop	23
Avoid variables with short names like md	24
A method should have only one exit point, and that should be the last statement in the method	28

org/musicontroller/security/IUser.java

Violation	Line
Avoid modifiers which are implied by the context	22
Avoid modifiers which are implied by the context	27
Avoid variables with short names like id	27
Avoid modifiers which are implied by the context	32
Avoid modifiers which are implied by the context	38
Avoid modifiers which are implied by the context	43
Avoid modifiers which are implied by the context	48
Avoid modifiers which are implied by the context	53
Avoid modifiers which are implied by the context	58
Avoid modifiers which are implied by the context	63
Avoid modifiers which are implied by the context	69
Avoid modifiers which are implied by the context	75
Avoid modifiers which are implied by the context	81
Avoid modifiers which are implied by the context	87
Avoid modifiers which are implied by the context	95
Avoid modifiers which are implied by the context	100
Avoid modifiers which are implied by the context	106

org/musicontroller/security/Role.java

Violation	Line
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	25
Avoid variables with short names like id	50

org/musicontroller/security/ServiceRoleProvider.java

Violation	Line
Possible unsafe assignment to a non-final static field in a constructor.	19
Assigning an Object to null is a code smell. Consider refactoring.	22
Avoid variables with short names like ap	25

org/musicontroller/security/User.java

Violation	Line
Use explicit scoping instead of the default package private level	22
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	25
Avoid excessively long variable names like _credentialsExpired	26
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	26
Avoid excessively long variable names like _encryptedPassword	29
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	32
Assigning an Object to null is a code smell. Consider refactoring.	48
Avoid variables with short names like id	58
Use bitwise inversion to invert boolean values	84
Avoid using if statements without curly braces	110
A method should have only one exit point, and that should be the last statement in the method	110
A method should have only one exit point, and that should be the last statement in the method	115
Use bitwise inversion to invert boolean values	138
Avoid variables with short names like o	194
Avoid using if statements without curly braces	195
A method should have only one exit point, and that should be the last statement in the method	195
A method should have only one exit point, and that should be the last statement in the method	198

org/musicontroller/security/UserDao.java

Violation	Line
Avoid modifiers which are implied by the context	26
Avoid modifiers which are implied by the context	33
Avoid variables with short names like id	33
Avoid modifiers which are implied by the context	41
Avoid modifiers which are implied by the context	47
Avoid modifiers which are implied by the context	54
Avoid modifiers which are implied by the context	60
Avoid modifiers which are implied by the context	66
Avoid modifiers which are implied by the context	71

org/musicontroller/service/FileUtils.java

Violation	Line
Avoid unused imports such as 'org.musicontroller.importer.ImporterException'	6
Possible unsafe assignment to a non-final static field in a constructor.	24
Assigning an Object to null is a code smell. Consider refactoring.	30
A signature (constructor or method) shouldn't have Exception in throws declaration	38
These nested if statements could be combined	41 - 43
Avoid throwing raw exception types	42
A signature (constructor or method) shouldn't have Exception in throws declaration	51
A method should have only one exit point, and that should be the last statement in the method	141
A method should have only one exit point, and that should be the last statement in the method	145

org/musicontroller/service/McService.java

Violation	Line
Avoid modifiers which are implied by the context	45
Avoid modifiers which are implied by the context	65
Avoid modifiers which are implied by the context	72
Avoid modifiers which are implied by the context	82
Avoid modifiers which are implied by the context	95
Avoid modifiers which are implied by the context	107
Avoid modifiers which are implied by the context	119
Avoid modifiers which are implied by the context	131
Avoid modifiers which are implied by the context	141
Avoid modifiers which are implied by the context	155
Avoid modifiers which are implied by the context	161
Avoid modifiers which are implied by the context	172
Avoid modifiers which are implied by the context	180
Avoid modifiers which are implied by the context	190
Avoid modifiers which are implied by the context	200
Avoid modifiers which are implied by the context	209
Avoid modifiers which are implied by the context	222
Avoid modifiers which are implied by the context	229
Avoid modifiers which are implied by the context	238
Avoid modifiers which are implied by the context	254
Avoid modifiers which are implied by the context	261
Avoid modifiers which are implied by the context	270
Avoid modifiers which are implied by the context	277
Avoid modifiers which are implied by the context	284
Avoid modifiers which are implied by the context	291
Avoid modifiers which are implied by the context	300
Avoid modifiers which are implied by the context	308
Avoid modifiers which are implied by the context	315
Avoid modifiers which are implied by the context	324
Avoid excessively long variable names like selectedKeywordIds	324
Avoid modifiers which are implied by the context	334
Avoid modifiers which are implied by the context	348
Avoid variables with short names like i	348
Avoid modifiers which are implied by the context	356
Avoid modifiers which are implied by the context	364
Avoid modifiers which are implied by the context	376
Avoid modifiers which are implied by the context	384
Avoid modifiers which are implied by the context	391
Avoid modifiers which are implied by the context	400
Avoid modifiers which are implied by the context	407
Avoid modifiers which are implied by the context	414
Avoid modifiers which are implied by the context	421
Avoid modifiers which are implied by the context	428

org/musicontroller/service/McServiceImpl.java

Violation	Line
The class 'McServiceImpl' has a Cyclomatic Complexity of 4 (Highest = 13).	58 - 773
Each class should declare at least one constructor	58 - 773
A method should have only one exit point, and that should be the last statement in the method	79
String.trim().length() ==0 is an inefficient way to validate an empty String	81
A method should have only one exit point, and that should be the last statement in the method	82
The method 'addMusician' has a Cyclomatic Complexity of 12.	94 - 148
A method should have only one exit point, and that should be the last statement in the method	96
A method should have only one exit point, and that should be the last statement in the method	99
A method should have only one exit point, and that should be the last statement in the method	152
A method should have only one exit point, and that should be the last statement in the method	155
The method 'deleteMusician' has a Cyclomatic Complexity of 13.	184 - 244
A method should have only one exit point, and that should be the last statement in the method	186
A method should have only one exit point, and that should be the last statement in the method	189
A method should have only one exit point, and that should be the last statement in the method	192
The method 'deleteMusician' has a Cyclomatic Complexity of 10.	246 - 278
A method should have only one exit point, and that should be the last statement in the method	249
A method should have only one exit point, and that should be the last statement in the method	252
A method should have only one exit point, and that should be the last statement in the method	366
String.trim().length() ==0 is an inefficient way to validate an empty String	368
A method should have only one exit point, and that should be the last statement in the method	369
A method should have only one exit point, and that should be the last statement in the method	396
A method should have only one exit point, and that should be the last statement in the method	416
A method should have only one exit point, and that should be the last statement in the method	432
Avoid variables with short names like p	434
A method should have only one exit point, and that should be the last statement in the method	448
Avoid variables with short names like p	450
Consider simply returning the value vs storing it in local variable 'covers'	452
Avoid reassigning parameters such as 'keywords'	455
A method should have only one exit point, and that should be the last statement in the method	457
String.trim().length() ==0 is an inefficient way to validate an empty String	459
A method should have only one exit point, and that should be the last statement in the method	460
A method should have only one exit point, and that should be the last statement in the method	463
A method should have only one exit point, and that should be the last statement in the method	469
Avoid variables with short names like kw	481
Avoid empty catch blocks	487 - 489
Avoid variables with short names like dj	504
Avoid reassigning parameters such as 'bandName'	514
Avoid reassigning parameters such as 'name'	514
These nested if statements could be combined	531 - 539
A method should have only one exit point, and that should be the last statement in the method	554
A method should have only one exit point, and that should be the last statement in the method	561
Avoid reassigning parameters such as 'bandName'	574
Avoid reassigning parameters such as 'band'	574
Avoid if (x != y) ..; else ..;	583 - 593
Avoid variables with short names like id	603
Avoid excessively long variable names like selectedKeywordIds	607
Avoid if (x != y) ..; else ..;	609 - 616
A method should have only one exit point, and that should be the last statement in the method	613
A method should have only one exit point, and that should be the last statement in the method	629
Avoid variables with short names like p	669
Avoid variables with short names like it	672
Avoid variables with short names like in	675
Avoid using if statements without curly braces	684
A method should have only one exit point, and that should be the last statement in the method	705
A method should have only one exit point, and that should be the last statement in the method	726
Avoid excessively long variable names like persistentCandidates	730
A method should have only one exit point, and that should be the last statement in the method	752

org/musicontroller/service/UserService.java

Violation	Line
Avoid modifiers which are implied by the context	20
Avoid variables with short names like id	20
Avoid modifiers which are implied by the context	27
A signature (constructor or method) shouldn't have Exception in throws declaration	27
Avoid modifiers which are implied by the context	33
Avoid modifiers which are implied by the context	40
Avoid modifiers which are implied by the context	46

org/musicontroller/service/UserServiceImpl.java

Violation	Line
Each class should declare at least one constructor	14 - 80
A signature (constructor or method) shouldn't have Exception in throws declaration	37
Avoid throwing raw exception types	39
Avoid variables with short names like id	74

org/musicontroller/songselection/AdvancedRandomSongSelector.java

Violation	Line
The class 'AdvancedRandomSongSelector' has a Cyclomatic Complexity of 4 (Highest = 15).	21 - 550
The field name indicates a constant but its modifiers do not	27
Private field '_bandPopularity' could be made final; it is only initialized in the declaration or constructor.	34
Avoid excessively long variable names like _keywordPopularity	39
Private field '_keywordPopularity' could be made final; it is only initialized in the declaration or constructor.	39
A method should have only one exit point, and that should be the last statement in the method	81
Avoid reassigning parameters such as 'lpc'	101
A method should have only one exit point, and that should be the last statement in the method	103
Consider simply returning the value vs storing it in local variable 'result'	109
Avoid variables with short names like sb	127
The method 'calculateKeywordScore' has a Cyclomatic Complexity of 11.	180 - 237
Avoid variables with short names like sb	180
Avoid variables with short names like it	190
Avoid if (x != y) ..; else ..;	198 - 221
Consider simply returning the value vs storing it in local variable 'evScore'	250
Avoid variables with short names like n	259
Avoid variables with short names like i	259
Avoid variables with short names like n	276
Avoid variables with short names like n1	277
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	310
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	311
Avoid using if statements without curly braces	326
A method should have only one exit point, and that should be the last statement in the method	326
Avoid using if statements without curly braces	327
A method should have only one exit point, and that should be the last statement in the method	327
Avoid using if statements without curly braces	351
A method should have only one exit point, and that should be the last statement in the method	351
Avoid using if statements without curly braces	363
A method should have only one exit point, and that should be the last statement in the method	363
The method 'kwbSimilarityScore' has a Cyclomatic Complexity of 15.	475 - 544
Avoid variables with short names like sb	475
A method should have only one exit point, and that should be the last statement in the method	501

org/musicontroller/songselection/CandidateSelector.java

Violation	Line
Avoid modifiers which are implied by the context	21
Avoid modifiers which are implied by the context	31
Avoid modifiers which are implied by the context	37
Avoid modifiers which are implied by the context	43
Avoid modifiers which are implied by the context	50
Avoid modifiers which are implied by the context	58
Avoid modifiers which are implied by the context	65
Avoid modifiers which are implied by the context	72
Avoid modifiers which are implied by the context	79

org/musicontroller/songselection/LastPlayedContainer.java

Violation	Line
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	15
Private field '_maxHistory' could be made final; it is only initialized in the declaration or constructor.	15
Private field '_lastsongs' could be made final; it is only initialized in the declaration or constructor.	20
Object clone() should be implemented with super.clone()	63

org/musicontroller/songselection/LastPlayedEntry.java

Violation	Line
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	8
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	9
Private field '_songid' could be made final; it is only initialized in the declaration or constructor.	9

org/musicontroller/songselection/RandomCandidateSelector.java

Violation	Line
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	26
Avoid excessively long variable names like _playRequestInOrder	41
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	41
Avoid using if statements without curly braces	95
A method should have only one exit point, and that should be the last statement in the method	101

org/musicontroller/songselection/SongSelector.java

Violation	Line
Avoid modifiers which are implied by the context	19
Avoid modifiers which are implied by the context	25
Avoid modifiers which are implied by the context	31
Avoid modifiers which are implied by the context	37
Avoid modifiers which are implied by the context	43

org/musicontroller/streaming/CoverArtService.java

Violation	Line
Each class should declare at least one constructor	22 - 102
Avoid variables with short names like in	75

org/musicontroller/streaming/Downloader.java

Violation	Line
Each class should declare at least one constructor	37 - 279
Avoid variables with short names like id	60
Avoid variables with short names like id	82
Avoid variables with short names like in	112
Avoid using if statements without curly braces	122
Avoid using if statements without curly braces	131
Avoid if (x != y) ..; else ..;	152 - 192
Avoid using if statements without curly braces	182
String.indexOf(char) is faster than String.indexOf(String)	237
Avoid variables with short names like ze	245
Avoid variables with short names like in	247
Avoid using if statements without curly braces	256
Avoid variables with short names like ze	264
Avoid variables with short names like ps	266

org/musicontroller/streaming/IStreamController.java

Violation	Line
Avoid modifiers which are implied by the context	13
Avoid modifiers which are implied by the context	19

org/musicontroller/streaming/MpegOutputStream.java

Violation	Line
The class 'MpegOutputStream' has a Cyclomatic Complexity of 8 (Highest = 54).	30 - 571
Too many fields	30 - 571
Avoid excessively long variable names like LOWBANDWIDTHDETECTIONLENGTH	39
Avoid excessively long variable names like LOWBANDWIDTHSAMPLEDEPTH	43
Perhaps 'second' could be replaced by a local variable.	66
Perhaps 'third' could be replaced by a local variable.	67
Perhaps 'fourth' could be replaced by a local variable.	68
Perhaps '_todiscard' could be replaced by a local variable.	70
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	70
Perhaps 'vMajor' could be replaced by a local variable.	71
Perhaps 'vMinor' could be replaced by a local variable.	72
Perhaps 'flags' could be replaced by a local variable.	73
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	81
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	83
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	84
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	96
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	100
Overridable method 'reset' called during object construction	140
Use block level rather than method level synchronization	156 - 170
Avoid variables with short names like b	176
Use block level rather than method level synchronization	176 - 180
Avoid really long methods.	187 - 426
The method 'write' has a Cyclomatic Complexity of 54.	187 - 426
Avoid variables with short names like b	187
Avoid reassigning parameters such as 'off'	187
Avoid reassigning parameters such as 'off'	187
Avoid reassigning parameters such as 'off'	187
Avoid reassigning parameters such as 'off'	187
Avoid reassigning parameters such as 'off'	187
Avoid reassigning parameters such as 'off'	187
Avoid reassigning parameters such as 'off'	187
Avoid reassigning parameters such as 'off'	187
Avoid reassigning parameters such as 'off'	187
Avoid reassigning parameters such as 'off'	187
Avoid reassigning parameters such as 'off'	187
Avoid reassigning parameters such as 'off'	187
Avoid reassigning parameters such as 'off'	187
Avoid reassigning parameters such as 'off'	187
Avoid reassigning parameters such as 'off'	187
Avoid reassigning parameters such as 'off'	187
Avoid reassigning parameters such as 'off'	187
Avoid reassigning parameters such as 'off'	187
Avoid reassigning parameters such as 'off'	187
Avoid reassigning parameters such as 'len'	187
Avoid reassigning parameters such as 'len'	187
Avoid reassigning parameters such as 'len'	187
Avoid reassigning parameters such as 'len'	187
Avoid reassigning parameters such as 'len'	187
Avoid reassigning parameters such as 'len'	187
Avoid reassigning parameters such as 'len'	187
Avoid reassigning parameters such as 'len'	187
Avoid reassigning parameters such as 'len'	187
Avoid reassigning parameters such as 'len'	187
Avoid reassigning parameters such as 'len'	187
Avoid reassigning parameters such as 'len'	187
Avoid reassigning parameters such as 'len'	187
Avoid reassigning parameters such as 'len'	187
Avoid reassigning parameters such as 'len'	187
Avoid reassigning parameters such as 'len'	187
Avoid reassigning parameters such as 'len'	187
Avoid reassigning parameters such as 'len'	187
Avoid reassigning parameters such as 'len'	187
Use block level rather than method level synchronization	187 - 426
Avoid using if statements without curly braces	188
A method should have only one exit point, and that should be the last statement in the method	188
These nested if statements could be combined	216 - 227
A method should have only one exit point, and that should be the last statement in the method	225
These nested if statements could be combined	230 - 243
A method should have only one exit point, and that should be the last statement in the method	241
These nested if statements could be combined	247 - 258
A method should have only one exit point, and that should be the last statement in the method	256
These nested if statements could be combined	261 - 272
A method should have only one exit point, and that should be the last statement in the method	270
These nested if statements could be combined	275 - 280
These nested if statements could be combined	283 - 288
These nested if statements could be combined	291 - 296
These nested if statements could be combined	299 - 304
These nested if statements could be combined	307 - 312
These nested if statements could be combined	315 - 320
These nested if statements could be combined	323 - 333
A method should have only one exit point, and that should be the last statement in the method	344
These nested if statements could be combined	349 - 361
A method should have only one exit point, and that should be the last statement in the method	359
These nested if statements could be combined	364 - 369
These nested if statements could be combined	372 - 402
A method should have only one exit point, and that should be the last statement in the method	388
A method should have only one exit point, and that should be the last statement in the method	395
A method should have only one exit point, and that should be the last statement in the method	400
Avoid variables with short names like c	413
The method 'updateBitrateArray' has a Cyclomatic Complexity of 15.	432 - 449
Switch statements should have a default label	433 - 448
Use block level rather than method level synchronization	478 - 481
Avoid empty if statements	525 - 527

org/musicontroller/streaming/PlaylistGenerator.java

Violation	Line
Each class should declare at least one constructor	22 - 88
Use explicit scoping instead of the default package private level	25
Avoid variables with short names like ps	63

org/musicontroller/streaming/RssService.java

Violation	Line
The class 'RssService' has a Cyclomatic Complexity of 3 (Highest = 11).	30 - 177
Each class should declare at least one constructor	30 - 177
Avoid variables with short names like id	46
Consider simply returning the value vs storing it in local variable 'link'	57
The method 'service' has a Cyclomatic Complexity of 11.	64 - 147
Avoid variables with short names like id	67
Avoid variables with short names like ca	85
Avoid variables with short names like dl	96
Avoid variables with short names like es	116
Avoid variables with short names like es	128
Avoid empty catch blocks	137 - 139
Avoid using if statements without curly braces	141

org/musicontroller/streaming/ShoutcastOutputStream.java

Violation	Line
Avoid excessively long variable names like DEFAULT_METADATA_INTERVAL	16
Avoid excessively long variable names like METADATA_REPEAT_INTERVAL	17
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	18
Perhaps 'intervalcounter' could be replaced by a local variable.	19
Avoid using if statements without curly braces	63
Avoid variables with short names like b	69
Use block level rather than method level synchronization	69 - 74
Avoid variables with short names like b	76
Use block level rather than method level synchronization	76 - 88
Use block level rather than method level synchronization	90 - 93

org/musicontroller/streaming/SkipException.java

Violation	Line
Each class should declare at least one constructor	3 - 7

org/musicontroller/streaming/StreamMaster.java

Violation	Line
Each class should declare at least one constructor	20 - 73
Avoid variables with short names like dj	42

org/musicontroller/streaming/StreamService.java

Violation	Line
The class 'StreamService' has a Cyclomatic Complexity of 3 (Highest = 13).	33 - 259
Each class should declare at least one constructor	33 - 259
Use explicit scoping instead of the default package private level	36
The method 'service' has a Cyclomatic Complexity of 13.	74 - 147
Avoid variables with short names like dj	79
Avoid variables with short names like dj	154
Avoid variables with short names like tx	159
Avoid using if statements without curly braces	185
Avoid variables with short names like dj	193
Avoid variables with short names like in	194
Avoid variables with short names like s	212
Avoid variables with short names like in	242
Avoid assigments in operands	248 - 255

org/varienaja/comments/AmazonCommentService.java

Violation	Line
Each class should declare at least one constructor	18 - 92
Avoid variables with short names like df	61
When instantiating a SimpleDateFormat object, specify a Locale	61
Avoid variables with short names like r	63
Avoid variables with short names like er	77

org/varienaja/comments/Comment.java

Violation	Line
Private field '_source' could be made final; it is only initialized in the declaration or constructor.	16
Private field '_elements' could be made final; it is only initialized in the declaration or constructor.	17
Avoid variables with short names like o	70
Avoid using if statements without curly braces	71
A method should have only one exit point, and that should be the last statement in the method	71
Avoid variables with short names like sb	95

org/varienaja/comments/CommentDAO.java

Violation	Line
Private field '_comments' could be made final; it is only initialized in the declaration or constructor.	35
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	39
It is a good practice to call super() in a constructor	46 - 49
Avoid variables with short names like ch	91
Each class should declare at least one constructor	104 - 228
Avoid protected fields in a final class. Change to private or package access.	106
Avoid protected fields in a final class. Change to private or package access.	107
Avoid protected fields in a final class. Change to private or package access.	108
Avoid protected fields in a final class. Change to private or package access.	109
Avoid protected fields in a final class. Change to private or package access.	110
Avoid variables with short names like id	120
Use block level rather than method level synchronization	120 - 173
A method should have only one exit point, and that should be the last statement in the method	123
Avoid variables with short names like tf	128
Avoid variables with short names like hd	129
Avoid variables with short names like t	130
The String literal "CDATA" appears 6 times in this file; the first occurrence is on line 138	138
A method should have only one exit point, and that should be the last statement in the method	163
Avoid printStackTrace(); use a logger call instead.	167
Avoid printStackTrace(); use a logger call instead.	169
Avoid variables with short names like id	184
Avoid variables with short names like xr	190
A method should have only one exit point, and that should be the last statement in the method	197
Avoid variables with short names like id	223
Consider simply returning the value vs storing it in local variable 'storage'	225

org/varienaja/comments/CommentElement.java

Violation	Line
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	16
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	17
Avoid variables with short names like id	40

org/varienaja/comments/CommentService.java

Violation	Line
The class 'CommentService' has a Cyclomatic Complexity of 2 (Highest = 10).	30 - 335
Each class should declare at least one constructor	30 - 335
A method should have only one exit point, and that should be the last statement in the method	95
The method 'enhanceComment' has a Cyclomatic Complexity of 10.	147 - 237
Avoid variables with short names like sb	150
Avoid variables with short names like it	179
Avoid variables with short names like p	183
Avoid excessively long variable names like somethingHyperlinked	185
When doing a String.toLowerCase()/toUpperCase() call, use a Locale	198
Avoid unused method parameters such as 'playlist'	276 - 278

org/varienaja/util/DateTools.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	1 - 242
Each class should declare at least one constructor	14 - 242
Avoid variables with short names like d1	73
Avoid variables with short names like d2	73
Avoid variables with short names like d1	85
Avoid variables with short names like d2	85
Avoid using if statements without curly braces	86
A method should have only one exit point, and that should be the last statement in the method	86
Avoid variables with short names like d	95
Avoid variables with short names like d	101
Avoid variables with short names like d	105
Avoid variables with short names like d	109
Avoid using if statements without curly braces	110
A method should have only one exit point, and that should be the last statement in the method	110
Avoid variables with short names like df	112
Avoid using if statements without curly braces	124
A method should have only one exit point, and that should be the last statement in the method	124
Avoid variables with short names like df	126
A method should have only one exit point, and that should be the last statement in the method	129
Avoid variables with short names like g	140
Avoid variables with short names like Y	141
Avoid variables with short names like M	142
Avoid variables with short names like D	143
Avoid variables with short names like g	153
Avoid variables with short names like Y	154
Avoid variables with short names like M	155
Avoid variables with short names like g	161
Avoid variables with short names like g	170
Avoid variables with short names like Y	172
Avoid variables with short names like M	173
Avoid variables with short names like D	174
Avoid variables with short names like dd	183
Avoid variables with short names like mm	183
Avoid variables with short names like g	184
Avoid variables with short names like dd	188
Avoid variables with short names like mm	188
Avoid variables with short names like h	188
Avoid variables with short names like m	188
Avoid variables with short names like s	188
Avoid variables with short names like g	189
Avoid variables with short names like d	198
Avoid using if statements without curly braces	200
Avoid variables with short names like d	212
Avoid using if statements without curly braces	213
A method should have only one exit point, and that should be the last statement in the method	213
Avoid variables with short names like d	222
Avoid using if statements without curly braces	223
A method should have only one exit point, and that should be the last statement in the method	223
Avoid variables with short names like g	237

org/varienaja/util/DenseSet.java

Violation	Line
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	16
Overridable method 'setStart' called during object construction	19
Overridable method 'setEnd' called during object construction	20
Avoid using if statements without curly braces	28
Avoid variables with short names like l	39
Avoid variables with short names like o	43
A method should have only one exit point, and that should be the last statement in the method	46
Avoid variables with short names like l	53
A method should have only one exit point, and that should be the last statement in the method	59
A method should have only one exit point, and that should be the last statement in the method	62
Avoid variables with short names like l	117
A method should have only one exit point, and that should be the last statement in the method	138
Avoid variables with short names like l	150
Avoid if (x != y) ..; else ..;	152 - 178
A method should have only one exit point, and that should be the last statement in the method	175
Avoid variables with short names like l	194
Avoid using if statements without curly braces	197
A method should have only one exit point, and that should be the last statement in the method	197
Avoid variables with short names like sb	203
Avoid variables with short names like it	209
Avoid using if statements without curly braces	212
Avoid variables with short names like sb	223
Avoid variables with short names like it	224
Avoid reassigning parameters such as 'index'	246
A method should have only one exit point, and that should be the last statement in the method	250
Avoid variables with short names like l	261
Avoid variables with short names like o	265
Avoid variables with short names like r1	274
Avoid variables with short names like r2	276

org/varienaja/util/FileOperations.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	1 - 329
Each class should declare at least one constructor	20 - 329
Avoid if (x != y) ..; else ..;	34 - 57
A method should have only one exit point, and that should be the last statement in the method	35
Avoid variables with short names like fn	39
Avoid variables with short names like i	40
String.indexOf(char) is faster than String.indexOf(String)	40
Avoid reassigning parameters such as 'dstdir'	71
Avoid reassigning parameters such as 'dstdir'	71
Avoid reassigning parameters such as 'dst'	71
Avoid reassigning parameters such as 'dstdir'	104
Avoid reassigning parameters such as 'dstdir'	104
Avoid reassigning parameters such as 'dst'	104
These nested if statements could be combined	112 - 114
Avoid variables with short names like in	126
Avoid assigments in operands	133 - 135
Avoid variables with short names like in	149
Avoid variables with short names like in	162
Avoid variables with short names like in	177
A method should have only one exit point, and that should be the last statement in the method	203
A method should have only one exit point, and that should be the last statement in the method	215
A method should have only one exit point, and that should be the last statement in the method	226
These nested if statements could be combined	244 - 245
Avoid using if statements without curly braces	244 - 245
Avoid using if statements without curly braces	266
A method should have only one exit point, and that should be the last statement in the method	266
Avoid using if statements without curly braces	280
A method should have only one exit point, and that should be the last statement in the method	280
Avoid assigments in operands	298 - 311
Avoid printStackTrace(); use a logger call instead.	314

org/varienaja/util/LRUMap.java

Violation	Line
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	17
Private field '_max_entries' could be made final; it is only initialized in the declaration or constructor.	17
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	18
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	19
Private field '_name' could be made final; it is only initialized in the declaration or constructor.	20
Avoid variables with short names like v	42

org/varienaja/util/RandomNumberGenerator.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	2 - 16
Each class should declare at least one constructor	6 - 16
Avoid variables with short names like n	9
Singleton is not thread safe	10 - 12

org/varienaja/util/SelectiveOpenSessionInViewFilter.java

Violation	Line
Private field '_filterMap' could be made final; it is only initialized in the declaration or constructor.	22
It is a good practice to call super() in a constructor	29 - 32

org/varienaja/util/StringUtil.java

Violation	Line
Avoid excessively long variable names like HTML_SUBSTITUTIONS	35
Document empty constructor	56
Avoid variables with short names like s	67
Avoid reassigning parameters such as 's'	67
A method should have only one exit point, and that should be the last statement in the method	69
Avoid variables with short names like s	85
Avoid variables with short names like s	96
A method should have only one exit point, and that should be the last statement in the method	110
Use block level rather than method level synchronization	129 - 150
A method should have only one exit point, and that should be the last statement in the method	134
A method should have only one exit point, and that should be the last statement in the method	140
A method should have only one exit point, and that should be the last statement in the method	146
A method should have only one exit point, and that should be the last statement in the method	162
This call to Collection.toArray() may be optimizable	177
Avoid variables with short names like in	187
This call to Collection.toArray() may be optimizable	199
Avoid variables with short names like u	216
A method should have only one exit point, and that should be the last statement in the method	218
Avoid variables with short names like a	227
Avoid variables with short names like b	227
Avoid variables with short names like s	236
A method should have only one exit point, and that should be the last statement in the method	238
A method should have only one exit point, and that should be the last statement in the method	244
A method should have only one exit point, and that should be the last statement in the method	247
A method should have only one exit point, and that should be the last statement in the method	250
A signature (constructor or method) shouldn't have Exception in throws declaration	261
Avoid variables with short names like s	261
A method should have only one exit point, and that should be the last statement in the method	263
A signature (constructor or method) shouldn't have Exception in throws declaration	275
Avoid variables with short names like s	275
A method should have only one exit point, and that should be the last statement in the method	277
A method should have only one exit point, and that should be the last statement in the method	314
Consider simply returning the value vs storing it in local variable 'capWord'	314
Avoid reassigning parameters such as 'query'	326
Avoid using if statements without curly braces	327
A method should have only one exit point, and that should be the last statement in the method	327
When doing a String.toLowerCase()/toUpperCase() call, use a Locale	328
These nested if statements could be combined	332 - 334
When doing a String.toLowerCase()/toUpperCase() call, use a Locale	332
A method should have only one exit point, and that should be the last statement in the method	333

org/varienaja/util/TolerantZipInputStream.java

Violation	Line
The class 'TolerantZipInputStream' has a Cyclomatic Complexity of 4 (Highest = 13).	32 - 423
Private field 'crc' could be made final; it is only initialized in the declaration or constructor.	35
Private field 'tmpbuf' could be made final; it is only initialized in the declaration or constructor.	37
Avoid variables with short names like in	60
Avoid throwing null pointer exceptions	63
Avoid assigments in operands	81 - 83
A method should have only one exit point, and that should be the last statement in the method	82
Avoid empty while statements	99
Avoid using while statements without curly braces	99
A method should have only one exit point, and that should be the last statement in the method	117
The method 'read' has a Cyclomatic Complexity of 12.	140 - 181
The user-supplied array 'b' is stored directly	140
The user-supplied array 'b' is stored directly	140
Avoid variables with short names like b	140
Avoid reassigning parameters such as 'len'	140
Avoid reassigning parameters such as 'len'	140
Avoid reassigning parameters such as 'len'	140
A method should have only one exit point, and that should be the last statement in the method	145
A method should have only one exit point, and that should be the last statement in the method	149
A switch statement does not contain a break	151 - 180
Assigning an Object to null is a code smell. Consider refactoring.	157
A method should have only one exit point, and that should be the last statement in the method	161
Assigning an Object to null is a code smell. Consider refactoring.	165
A method should have only one exit point, and that should be the last statement in the method	166
Avoid variables with short names like n	191
Perhaps 'b' could be replaced by a local variable.	225
Avoid variables with short names like b	225
A method should have only one exit point, and that should be the last statement in the method	234
A method should have only one exit point, and that should be the last statement in the method	237
Avoid variables with short names like e	249
Avoid variables with short names like bb	270
The method 'getUTF8String' has a Cyclomatic Complexity of 13.	280 - 340
Avoid variables with short names like b	280
Avoid reassigning parameters such as 'off'	280
Avoid reassigning parameters such as 'off'	280
Avoid reassigning parameters such as 'off'	280
Avoid reassigning parameters such as 'off'	280
Avoid variables with short names like i	284
Avoid variables with short names like c	286
Avoid variables with short names like cs	316
Avoid variables with short names like c	319
Avoid variables with short names like t	331
Avoid variables with short names like e	356
Avoid variables with short names like n	357
Avoid if (x != y) ..; else ..;	365 - 375
Avoid variables with short names like b	397
Avoid reassigning parameters such as 'off'	397
Avoid reassigning parameters such as 'len'	397
Avoid variables with short names like n	399
Avoid variables with short names like b	412
Avoid variables with short names like b	420

org/varienaja/util/ZipConstants.java

Violation	Line
An Interface should be used only to model a behaviour; consider converting this to a class.	17 - 81
Avoid modifiers which are implied by the context	21
Avoid modifiers which are implied by the context	22
Avoid modifiers which are implied by the context	23
Avoid modifiers which are implied by the context	24
Avoid modifiers which are implied by the context	29
Avoid modifiers which are implied by the context	30
Avoid modifiers which are implied by the context	31
Avoid modifiers which are implied by the context	32
Avoid modifiers which are implied by the context	37
Avoid modifiers which are implied by the context	38
Avoid modifiers which are implied by the context	39
Avoid modifiers which are implied by the context	40
Avoid modifiers which are implied by the context	41
Avoid modifiers which are implied by the context	42
Avoid modifiers which are implied by the context	43
Avoid modifiers which are implied by the context	44
Avoid modifiers which are implied by the context	45
Avoid modifiers which are implied by the context	50
Avoid modifiers which are implied by the context	51
Avoid modifiers which are implied by the context	52
Avoid modifiers which are implied by the context	57
Avoid modifiers which are implied by the context	58
Avoid modifiers which are implied by the context	59
Avoid modifiers which are implied by the context	60
Avoid modifiers which are implied by the context	61
Avoid modifiers which are implied by the context	62
Avoid modifiers which are implied by the context	63
Avoid modifiers which are implied by the context	64
Avoid modifiers which are implied by the context	65
Avoid modifiers which are implied by the context	66
Avoid modifiers which are implied by the context	67
Avoid modifiers which are implied by the context	68
Avoid modifiers which are implied by the context	69
Avoid modifiers which are implied by the context	70
Avoid modifiers which are implied by the context	71
Avoid modifiers which are implied by the context	76
Avoid modifiers which are implied by the context	77
Avoid modifiers which are implied by the context	78
Avoid modifiers which are implied by the context	79
Avoid modifiers which are implied by the context	80

org/varienaja/util/coverart/AbstractCoverArtFinder.java

Violation	Line
Each class should declare at least one constructor	18 - 75
Avoid variables with short names like in	45
Avoid variables with short names like in	58
Avoid printStackTrace(); use a logger call instead.	64
Avoid printStackTrace(); use a logger call instead.	67
Avoid printStackTrace(); use a logger call instead.	70

org/varienaja/util/coverart/AmazonCoverArtFinder.java

Violation	Line
Each class should declare at least one constructor	15 - 47
Avoid printStackTrace(); use a logger call instead.	41

org/varienaja/util/coverart/CoverArtManager.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	1 - 139
Each class should declare at least one constructor	21 - 139
Avoid variables with short names like id	33
Avoid variables with short names like in	33
Avoid variables with short names like id	45
Consider simply returning the value vs storing it in local variable 'target'	48
Avoid variables with short names like id	55
Avoid empty if statements	65 - 67
Avoid variables with short names like id	78
Avoid variables with short names like id	91
A method should have only one exit point, and that should be the last statement in the method	93
Avoid variables with short names like sb	110
Avoid variables with short names like sb	132

org/varienaja/util/coverart/CoverArtProcessor.java

Violation	Line
Each class should declare at least one constructor	18 - 107
Private field '_finder' could be made final; it is only initialized in the declaration or constructor.	27
Private field '_band' could be made final; it is only initialized in the declaration or constructor.	28
Private field '_album' could be made final; it is only initialized in the declaration or constructor.	29
Avoid variables with short names like id	95

org/varienaja/util/coverart/CoverArtSearchResult.java

Violation	Line
The class 'CoverArtSearchResult' has a Cyclomatic Complexity of 2 (Highest = 11).	7 - 126
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	12
Private field '_width' could be made final; it is only initialized in the declaration or constructor.	12
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	13
Private field '_height' could be made final; it is only initialized in the declaration or constructor.	13
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	14
Private field '_size' could be made final; it is only initialized in the declaration or constructor.	14
Avoid variables with short names like w	16
Avoid variables with short names like h	16
Avoid variables with short names like w	23
Avoid variables with short names like h	23
Avoid variables with short names like o	57
A method should have only one exit point, and that should be the last statement in the method	61 - 64
The method 'compareTo' has a Cyclomatic Complexity of 11.	74 - 124
A method should have only one exit point, and that should be the last statement in the method	80
A method should have only one exit point, and that should be the last statement in the method	82
A method should have only one exit point, and that should be the last statement in the method	87
A method should have only one exit point, and that should be the last statement in the method	89
A method should have only one exit point, and that should be the last statement in the method	101
A method should have only one exit point, and that should be the last statement in the method	104
A method should have only one exit point, and that should be the last statement in the method	107
A method should have only one exit point, and that should be the last statement in the method	110
A method should have only one exit point, and that should be the last statement in the method	112
A method should have only one exit point, and that should be the last statement in the method	119

org/varienaja/util/coverart/GoogleCoverArtFinder.java

Violation	Line
Each class should declare at least one constructor	15 - 102
Avoid variables with short names like in	39
Avoid variables with short names like sb	42
Avoid assigments in operands	45 - 47
Avoid assigments in operands	50 - 56
Avoid variables with short names like sb	61
String.indexOf(char) is faster than String.indexOf(String)	76
Avoid empty catch blocks	77 - 79
Avoid empty catch blocks	79 - 81

org/varienaja/util/coverart/ICoverArtFinder.java

Violation	Line
Avoid modifiers which are implied by the context	17

org/varienaja/util/coverart/ImageScaler.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	1 - 139
Avoid unused imports such as 'java.awt.GraphicsEnvironment'	5
Avoid unused imports such as 'org.apache.log4j.Logger'	18
Each class should declare at least one constructor	28 - 139
A method should have only one exit point, and that should be the last statement in the method	51
Avoid empty catch blocks	62 - 64
A signature (constructor or method) shouldn't have Exception in throws declaration	74
A method should have only one exit point, and that should be the last statement in the method	77
A signature (constructor or method) shouldn't have Exception in throws declaration	89
A method should have only one exit point, and that should be the last statement in the method	91
A signature (constructor or method) shouldn't have Exception in throws declaration	103

org/varienaja/util/coverart/YahooCoverArtFinder.java

Violation	Line
Each class should declare at least one constructor	15 - 112
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).	17
Avoid variables with short names like in	38
Avoid variables with short names like sb	41
Avoid assigments in operands	44 - 46
Avoid assigments in operands	50 - 56
Avoid variables with short names like sb	61
Avoid using if statements without curly braces	66
A method should have only one exit point, and that should be the last statement in the method	66
Avoid empty catch blocks	87 - 89
Avoid empty catch blocks	89 - 91

org/varienaja/util/wikipedia/WikiContentHelper.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	1 - 68
Each class should declare at least one constructor	7 - 68
Consider simply returning the value vs storing it in local variable 'step2'	19
Consider simply returning the value vs storing it in local variable 'step2'	31
Consider simply returning the value vs storing it in local variable 'result'	43
Consider simply returning the value vs storing it in local variable 'step2'	54
Consider simply returning the value vs storing it in local variable 'result'	65

org/varienaja/util/wikipedia/WikipediaException.java

Violation	Line
Avoid variables with short names like e	15

org/varienaja/util/wikipedia/WikipediaSearcher.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	1 - 440
Each class should declare at least one constructor	31 - 440
A method should have only one exit point, and that should be the last statement in the method	106
A method should have only one exit point, and that should be the last statement in the method	111
A method should have only one exit point, and that should be the last statement in the method	120
A method should have only one exit point, and that should be the last statement in the method	125
A method should have only one exit point, and that should be the last statement in the method	169
A method should have only one exit point, and that should be the last statement in the method	185
Avoid variables with short names like in	201
A method should have only one exit point, and that should be the last statement in the method	207
Consider simply returning the value vs storing it in local variable 'doc'	207
Avoid variables with short names like in	224
Avoid variables with short names like sb	259
Avoid variables with short names like in	297
A method should have only one exit point, and that should be the last statement in the method	302
A method should have only one exit point, and that should be the last statement in the method	330
A method should have only one exit point, and that should be the last statement in the method	347
String.indexOf(char) is faster than String.indexOf(String)	353
String.indexOf(char) is faster than String.indexOf(String)	355
String.indexOf(char) is faster than String.indexOf(String)	357
Avoid variables with short names like sb	389

Project Documentation

PMD Results

Files

org/musicontroller/DJ.java

org/musicontroller/DJFactory.java

org/musicontroller/DJImpl.java

org/musicontroller/MusiController.java

org/musicontroller/MusiControllerImpl.java

org/musicontroller/SongChangeListener.java

org/musicontroller/UserProperties.java

org/musicontroller/core/AIBag.java

org/musicontroller/core/AIRelation.java

org/musicontroller/core/Artist.java

org/musicontroller/core/Band.java

org/musicontroller/core/Contract_BA.java

org/musicontroller/core/Contract_PS.java

org/musicontroller/core/Contract_SK.java

org/musicontroller/core/Event.java

org/musicontroller/core/EventCountLookup.java

org/musicontroller/core/Eventkind.java

org/musicontroller/core/Instrument.java

org/musicontroller/core/Keyword.java

org/musicontroller/core/KeywordCycleException.java

org/musicontroller/core/Keywordbag.java

org/musicontroller/core/Link.java

org/musicontroller/core/LinkableAbs.java

org/musicontroller/core/MusicDirProvider.java

org/musicontroller/core/Playlist.java

org/musicontroller/core/Role.java

org/musicontroller/core/Song.java

org/musicontroller/core/jobs/ConsistencyCheckJob.java

org/musicontroller/core/jobs/ImportJob.java

org/musicontroller/core/jobs/IndexJob.java

org/musicontroller/core/jobs/MetadataExtractJob.java

org/musicontroller/core/jobs/PodcastUpdateJob.java

org/musicontroller/core/jobs/ReviewRefreshJob.java

org/musicontroller/core/searching/ISearcher.java

org/musicontroller/core/searching/Indexer.java

org/musicontroller/core/searching/Item.java

org/musicontroller/core/searching/MCSearcher.java

org/musicontroller/dao/BagAndKeywordUtils.java

org/musicontroller/dao/Dao.java

org/musicontroller/dao/HibernateDao.java

org/musicontroller/dao/PlaylistKey.java

org/musicontroller/gui/ArtistInfo.java

org/musicontroller/gui/BandInfo.java

org/musicontroller/gui/Bands.java

org/musicontroller/gui/Home.java

org/musicontroller/gui/Keywords.java

org/musicontroller/gui/Logon.java

org/musicontroller/gui/MyAccount.java

org/musicontroller/gui/NextToFieldErrorDisplayDelegate.java

org/musicontroller/gui/PlaylistInfo.java

org/musicontroller/gui/Podcasts.java

org/musicontroller/gui/Search.java

org/musicontroller/gui/SongInfo.java

org/musicontroller/gui/Welcome.java

org/musicontroller/gui/admin/Adduser.java

org/musicontroller/gui/admin/DoubleSongs.java

org/musicontroller/gui/admin/Keywordmanagement.java

org/musicontroller/gui/admin/RoleSelectionModel.java

org/musicontroller/gui/admin/Usermanagement.java

org/musicontroller/gui/components/AIList.java

org/musicontroller/gui/components/ArtistLink.java

org/musicontroller/gui/components/BandLink.java

org/musicontroller/gui/components/Border.java

org/musicontroller/gui/components/CoverArt.java

org/musicontroller/gui/components/CurrentlyPlaying.java

org/musicontroller/gui/components/EditLink.java

org/musicontroller/gui/components/EventList.java

org/musicontroller/gui/components/InstrumentLink.java

org/musicontroller/gui/components/KeywordLink.java

org/musicontroller/gui/components/KeywordList.java

org/musicontroller/gui/components/PlaylistLink.java

org/musicontroller/gui/components/PlaylistList.java

org/musicontroller/gui/components/PlaylistRequester.java

org/musicontroller/gui/components/PlaylistReviews.java

org/musicontroller/gui/components/SongLink.java

org/musicontroller/gui/components/SongList.java